GNOME Bugzilla – Bug 580425
Remove deprecated libgnome dependency
Last modified: 2009-08-07 00:29:30 UTC
http://live.gnome.org/LibgnomeMustDie This library will be removed for GNOME 3. ./configure.in: libgnome-2.0 >= 2.14.0 ./src/yelp-main.c:#include <libgnome/gnome-program.h> ./src/yelp-window.c:#include <libgnome/gnome-config.h> ./src/yelp-window.c:#include <libgnome/gnome-url.h> ./src/test-uri.c:#include <libgnome/gnome-init.h> ./src/test-uri.c:#include <libgnome/gnome-program.h> ./src/yelp-bookmarks.c:#include <libgnome/gnome-config.h> ./docs/help-parsing.txt:There are 3 proposed API calls for libgnome:
also see bug 580424
gnome-config fixed (see bug 570731).
Created attachment 133681 [details] [review] Remove unneeded includes of libgnome/gnome-config.h Now that bug #580425 removed the use of gnome-config we don't need the include anymore
Created attachment 133682 [details] [review] Remove unneeded include of libgnome/gnome-url.h gnome-url looks unused to me. Builds/runs fine without the include.
Would you accept a patch to get rid of libgnome by using EggSMClient? Many other modules have done so.
Created attachment 134371 [details] [review] Replace libgnome by using EggSMClient Patch to remove libgnome by using EggSMClient for session management. May need some testing. I seem to get wrong results back from egg_sm_client_is_resumed. Also setting the restart command does not like getting g_get_prgname () so using "yelp" instead. The patch includes the fixes in the other two patches.
I should have some free time again starting Monday. If yelp devs can confirm that they want to use eggsmclient I can take a look at this again and test/fix the issue with the current patch.
There is currently no way around using EggSMClient until bug 79285 gets resolved. The disadvantage of copying code is currently considered lower than the advantage of dropping libgnome.
<shaunm> the first two patches are trivial. I can commit those easy <shaunm> if yelp builds with them applied I take this as an "accepted_commit-now" for the first two items.
Cool, I'll commit those tonight. I'll see if I can find the bug in the EggSMClient too. It may even work currently. I just got some strange results but I seem to get them from other apps too. I'll test and attach a new patch if I find anything
Andre: In bug #571868 you committed my patch to the webkit branch "and rejected the commit to master". Am I supposed to do the same here? (+ why?)
Nope. I wrote "git [...] rejected the commit to master." Not me. :-)
In jhbuild we use <autotools id="yelp"> <branch revision="webkit"/> Thomas, can you commit your 2 patches to the webkit branch, please?
That would require that this commit to master is also committed to webkit: http://git.gnome.org/cgit/yelp/commit/?id=5b3356984a7a3b63928032a9a82175d9d73fee33 I wonder what else is in master but not webkit.
Argh, I was wrong. <shaunm> andre: master is what I'm working on. I don't believe I've ever made a commit to webkit <shaunm> commits on webkit ought to be only for the purpose of switching to webkit
Committed the two first patches to master: http://git.gnome.org/cgit/yelp/commit/?id=e6cda8725fbb1c9df3631dbf00afa5cf458ace47 http://git.gnome.org/cgit/yelp/commit/?id=eb2afcc9de05b04b53717ce267c378fe6b482ddc
Committed, thanks.