After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 577940 - Port to GtkBuilder
Port to GtkBuilder
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: baobab
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Fabio Marzocca
gnome-utils Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-04 16:22 UTC by Cosimo Cecchi
Modified: 2009-04-07 20:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
port to GtkBuilder (77.39 KB, patch)
2009-04-04 16:23 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2009-04-04 16:22:14 UTC
See attached patch.
Comment 1 Cosimo Cecchi 2009-04-04 16:23:24 UTC
Created attachment 132083 [details] [review]
port to GtkBuilder
Comment 2 Cosimo Cecchi 2009-04-04 16:59:34 UTC
Please note that I will modify the po/POTFILES.in list after committing, as another similar patch for gnome-dictionary is pending and I didn't want to mix up changes in the same file.
Comment 3 Paolo Borelli 2009-04-04 17:09:50 UTC
the patch looks ok from a quick review (I did not test it!)... if you wanted to go one extra step with the effort, I'd really like to take the chance to clean uo the code a bit and just use gtkbuilder as a private "one shot" object and store the actual widgets in the main struct
Comment 4 Cosimo Cecchi 2009-04-07 17:36:00 UTC
Committed to trunk after we talked about this on IRC. We can do the cleanup later in a follow-up.

2009-04-07  Cosimo Cecchi  <cosimoc@gnome.org>

	* data/Makefile.am:
	* data/baobab.glade:
	* src/Makefile.am:
	* src/baobab-prefs.c (create_props), (create_tree_props):
	* src/baobab-treeview.c (create_directory_treeview):
	* src/baobab-utils.c (set_ui_action_sens), (set_ui_widget_sens),
	(show_label):
	* src/baobab-utils.h:
	* src/baobab.c (check_menu_sens), (baobab_scan_location),
	(set_toolbar_visible), (set_statusbar_visible),
	(baobab_create_toolbar), (baobab_create_statusbar), (baobab_init),
	(initialize_ringschart), (main):
	* src/baobab.h:
	* src/callbacks.c (on_view_sb_activate):
	* src/callbacks.h:
	Port to GtkBuilder (#577940).
Comment 5 Fabio Marzocca 2009-04-07 20:30:07 UTC
Cosimo,

thank you very much for your cooperation.