GNOME Bugzilla – Bug 576976
Updating an FTP bookmark's address changes it's name
Last modified: 2014-02-17 21:29:17 UTC
this report has been filed here: https://bugs.edge.launchpad.net/ubuntu/+source/nautilus/+bug/340380 " Steps to reproduce : 1) add an authentified FTP bookmark using Places->Connect to server (give it a name and a default directory) 2) open nautilus and go to bookmars->edit bookmarks and change something in the ftp uri => the name is set to the value of the "default directory" set in 1)" Thanks in advance,
This behavior is present also in previous versions, and quite irritating. Bug #580578 is a duplicate of this.
*** Bug 580578 has been marked as a duplicate of this bug. ***
Confirming with master.
*** Bug 624822 has been marked as a duplicate of this bug. ***
Cosimo, could you describe how this should work instead?
Since Cosimo is not preset at this second, I will explain in his place. He could correct me later. I think the bookmark title should be the same as it was before opening the bookmark manager. It should not change. BTW, can someone acknowledge this bug and change the status.
*** Bug 611910 has been marked as a duplicate of this bug. ***
*** Bug 678533 has been marked as a duplicate of this bug. ***
Created attachment 255931 [details] [review] Patch to prevent nautilus to create a new name when changing the bookmark URI Hi, I think the issue is caused by nautilus bookmark editor, which actually creates a new bookmark when editing one. The code to create the new bookmark (which will replace the old one), checks whether the name field is changed. When it doesn't, it passes NULL to nautilus_bookmark_new, thus perhaps causing it to create a new name for the new bookmark based on the URI. Not sure why this is so. If this was expected behaviour, please ignore the patch.
Review of attachment 255931 [details] [review]: ::: src/nautilus-bookmarks-window.c @@ +520,2 @@ bookmark = nautilus_bookmark_new (location, + gtk_entry_get_text (GTK_ENTRY (self->priv->name_field))); I think this makes sense, but this function was the only user of self->priv->name_text_changed, so that should be removed entirely.
(In reply to comment #10) > Review of attachment 255931 [details] [review]: I think Emmanuel did not received bugzilla mail about your review, he was not in the CC list members of the bug, I've now manually added him, this is a nasty bugzilla bug that I've suffered myself too, where attaching a patch to a bug does not automatically include you in the CC list as you would expect the same way this is done for regular comments.
Ah, yes, just got the mail, thanks Nelson. I'll try to locate and remove self->priv->name_text_changed too. Thanks!
Created attachment 258084 [details] [review] Remove occurrences of name_text_changed Here's a small patch to remove the rest of the name_text_changed occurrences within the nautilus-bookmarks-window.c file. Sorry it took so long, and sorry I couldn't merge both in one patch. thanks.
Review of attachment 258084 [details] [review]: Looks good - can you squash the two patches together?
Created attachment 258204 [details] [review] Patch to prevent nautilus to create a new name when changing the bookmark URI Here it is (I think), trying to get the hang of it :-) Thanks
Thanks, I now pushed this to git master.