After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 576016 - DBus Plugin for Totem
DBus Plugin for Totem
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Plugins
2.25.x
Other All
: Normal minor
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-03-19 22:43 UTC by Lucky
Modified: 2009-04-01 18:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
totem dbus plugin v0.2.1 (1.32 KB, application/x-bzip)
2009-03-19 22:44 UTC, Lucky
  Details
Add D-Bus Service plugin to Totem (6.75 KB, patch)
2009-04-01 15:46 UTC, Philip Withnall
committed Details | Review

Description Lucky 2009-03-19 22:43:24 UTC
Plugin for sending notifications of currently playing tracks to DBus subsystem.

Other information:
I was developed d-bus plugin for totem:
http://lucky.awardspace.co.uk/totem-plugins

Now it's integrated with Gajim Jabber Messenger. If you find it useful, you can add it to totem distribution.
Sorry for my english ^_^
Comment 1 Lucky 2009-03-19 22:44:43 UTC
Created attachment 130995 [details]
totem dbus plugin v0.2.1
Comment 2 Philip Withnall 2009-04-01 15:46:14 UTC
Created attachment 131849 [details] [review]
Add D-Bus Service plugin to Totem

Here's a cleaned up version of the plugin. It releases its hold on the /org/gnome/Totem path when deactivated, which prevents problems when deactivating and immediately reactivating the plugin. I've also added a paragraph about it to the user manual, and sorted out the naming of a few things so they're a little nicer (e.g. dbusplugin -> dbus-service).

Note that for it to be committed to Totem trunk, it has to be relicenced to Totem's licence: GPLv2+ with an exception for non-GPL-compatible GStreamer plugins. Lucky, are you (and any other contributors) willing to relicence your contributions?
Comment 3 Bastien Nocera 2009-04-01 15:53:11 UTC
Looks fine to commit to trunk, once we have the relicensing agreed (noting along the way that it might not even be possible to ship a Totem plugin with that license in the first place, whether in Totem's tarball or somewhere else).
Comment 4 Bastien Nocera 2009-04-01 15:55:14 UTC
Oh, and we can remove --printplaying (bug #512232), and use libunique afterwards (bug #162822).
Comment 5 Lucky 2009-04-01 18:13:57 UTC
Yes, I agree with relicensing.
Comment 6 Philip Withnall 2009-04-01 18:58:11 UTC
Committed to trunk. Thanks Lucky.

2009-04-01  Philip Withnall  <philip@tecnocode.co.uk>

	* configure.in:
	* src/plugins/dbus-service/Makefile.am:
	* src/plugins/dbus-service/dbus-service.py:
	* src/plugins/dbus-service/dbus-service.totem-plugin.in: Added a
	D-Bus Service plugin by Lucky <lucky1.data@gmail.com>.
	(Closes: #576016)

2009-04-01  Philip Withnall  <philip@tecnocode.co.uk>

	* C/totem.xml: Added documentation for the new D-Bus Service plugin.