After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575038 - Cursor/caret mode breaks magic spacebar
Cursor/caret mode breaks magic spacebar
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.26.x (obsolete)
Other All
: Normal minor
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2009-03-12 08:45 UTC by Jan Nieuwenhuizen
Modified: 2013-09-13 00:59 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
gtkhtml patch (947 bytes, patch)
2010-04-28 18:00 UTC, Milan Crha
committed Details | Review

Description Jan Nieuwenhuizen 2009-03-12 08:45:31 UTC
Please describe the problem:
Assuming that the option for 'Enable Magic Spacebar' in Mail preferences
is enabled, enabling V[iew]/C[aret] mode breaks the magic spacebar.

Steps to reproduce:
1. enable Enable Magic Spacebar in Mail preferences
2. enable Caret/Cursor mode in View
3. use the spacebar to read all new mail


Actual results:
 - pressing SPACE scrolls the current message and will move to the
   next, but after that you have to click in the message text with
   the mouse, as if to re-enable "message view" again.  Only after
   that SPACE will scroll the message and go on to the next.  SPACE
   does not move to the next folder with unread messages.


Expected results:
pressing SPACE should behave just like when Caret mode is unchecked, ie
- move to the next unread message without
  having to use the mouse to reset focus.  after reading the last
  new message in a folder, SPACE should move to the next folder
  with unread messages and start reading the first unread one.


Does this happen every time?
yes

Other information:
Comment 1 Matthew Barnes 2009-06-28 22:05:58 UTC
This is on purpose, though I'm not entirely sure why.  The space/backspace key press handlers check for caret mode and abort the routine if it's enabled.

Srini, do you remember the rationale for this?
Comment 2 Srinivasa Ragavan 2009-06-29 04:30:58 UTC
It was me who started this feature and Johnny completed it. IIRC it was a bug in gtkhtml or a caret feature that SPACE wasn't emitted from gtkhtml.
Comment 3 Milan Crha 2010-04-28 17:06:25 UTC
Downstream bug report about the same with evolution 2.30.0:
https://bugzilla.redhat.com/show_bug.cgi?id=586118
Comment 4 Milan Crha 2010-04-28 18:00:46 UTC
Created attachment 159816 [details] [review]
gtkhtml patch

for gtkhtml;

Got it. Everything is working fine on evo side, only the GtkHtml is rejecting scroll commands when in caret mode. I do not think it's correct, thus removing this check from there.
Comment 5 Milan Crha 2010-04-28 18:04:50 UTC
Created commit 1a395fb in gtkhtml master (3.31.1+)
Created commit bf1997a in gtkhtml gnome-2-30 (3.30.2+)