After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 574813 - Add --with-gconf that would be independent of --with-gnome
Add --with-gconf that would be independent of --with-gnome
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2009-03-10 20:01 UTC by Vincent Untz
Modified: 2010-02-18 04:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.71 KB, patch)
2009-03-13 07:42 UTC, Jean Bréfort
committed Details | Review

Description Vincent Untz 2009-03-10 20:01:46 UTC
Currently, when --with-gnome isn't used, it also means gconf isn't used. I think people

I think it's bad because many people might not care about bonobo & friends but would still want to use gconf to manage the settings. So it'd be nice to be able to just have --with-gconf
Comment 1 Jean Bréfort 2009-03-11 05:23:32 UTC
--with-gnome is now obsolete. The core configuration code has been moved to goffice which now has a --without-gconf configure option.
Comment 2 Vincent Untz 2009-03-11 12:34:06 UTC
Then there's some things to fix in gnumeric:

configure.in: the tests for gconf are only done if --with-gnome is used. Maybe there should be something in the goffice pkg-config file for this?

schemas/Makefile.am: right now, the gconf schemas are only installed if --with-gnome is used.
Comment 3 Morten Welinder 2009-03-11 12:38:54 UTC
Somewhat relatedly, the use of GNM_WITH_GNOME in src/workbook-view.c
seems wrong.  Shouldn't we always call go_url_show (or whatever the
new variant was called)?
Comment 4 Jean Bréfort 2009-03-11 13:38:07 UTC
Vincent, you are right. I see the point. We can use either pkg-config (which needs a fix in goffice) or test if GOFFICE_WITH_GCONF is defined in goffice-features.h, so no --with-gconf option is needed in gnumeric.

Morten, a call to go_url_show should work in all cases, I think (or go_gtk_url_show if you need to pass the GdkScreen* for non win32 builds).
Comment 5 Morten Welinder 2009-03-11 15:40:11 UTC
I fixed the with-gnome dependency in workbook-view.c
Comment 6 Morten Welinder 2009-03-12 13:47:24 UTC
Jean: we already depend on HEAD goffice, so needing a fix there is fine.
Comment 7 Jean Bréfort 2009-03-12 14:08:57 UTC
Morten, the patch for #572910 would fix the goffice side. But this patch is blocked by our disagreement about the -lXext issue.
Comment 8 Morten Welinder 2009-03-12 23:20:59 UTC
Bug 572910 is now fixed.
Comment 9 Jean Bréfort 2009-03-13 07:42:40 UTC
Created attachment 130569 [details] [review]
Proposed patch

One day we should remove all the corba/bonobo code, imho.
Comment 10 Morten Welinder 2009-03-14 01:52:31 UTC
Dump it in.

> One day we should remove all the corba/bonobo code, imho.

We might.  Right now it ought to be isolated.
Comment 11 Jean Bréfort 2009-03-14 15:39:03 UTC
Fixed in trunk.
Comment 12 Andreas J. Guelzow 2010-02-18 04:54:02 UTC
*** Bug 610328 has been marked as a duplicate of this bug. ***