After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 573098 - Fail to properly detect MakeMaker version
Fail to properly detect MakeMaker version
Status: RESOLVED WONTFIX
Product: gnome-perl
Classification: Bindings
Component: Gtk2
unspecified
Other Windows
: Normal normal
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2009-02-25 11:00 UTC by Martin Schlemmer
Modified: 2009-03-08 19:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Gtk2-MM-version-fix.patch (405 bytes, patch)
2009-02-25 11:02 UTC, Martin Schlemmer
none Details | Review

Description Martin Schlemmer 2009-02-25 11:00:39 UTC
If the version number have a micro component, below is the result:

$ perl Makefile.PL
Set up gcc environment - gcc (4.3.2-tdm-2 mingw32) 4.3.2
Including generated API documentation...
Argument "6.42.1" isn't numeric in numeric ge (>=) at Makefile.PL line 270.
Note (probably harmless): No library found for -Wl,-luuid
Writing Makefile for Gtk2
Comment 1 Martin Schlemmer 2009-02-25 11:02:50 UTC
Created attachment 129482 [details] [review]
Gtk2-MM-version-fix.patch

Suggested patch that removes the micro part of the version in the comparison.

PS: This is the same for Glib - not sure about the newer stuff that uses the Pango module.
Comment 2 Torsten Schoenfeld 2009-03-08 19:07:50 UTC
The message is just a warning, and the affected code is only relevant when creating the tarball distribution.  So it's safe to ignore.

Also: a module's $VERSION really ought to be a proper floating point number.  Anything else is just broken.

And: we'll probably soon alter the affected part of the code to just always use META_MERGE, voiding the need for a version check.

Consequently, I don't think we will fix this.  But thanks for the report and the patch, anyway!