After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 572089 - Remove deprecated GTK+ symbols
Remove deprecated GTK+ symbols
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
2.25.x
Other Linux
: Normal trivial
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on: 572273
Blocks:
 
 
Reported: 2009-02-16 23:32 UTC by André Klapper
Modified: 2009-04-02 19:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description André Klapper 2009-02-16 23:32:02 UTC 
See http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/GTK%2B .
After fixing this, it could be helpful to always compile by using
make CFLAGS+="-DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED
-DGTK_DISABLE_DEPRECATED" in order to avoid breaking this again by accident.


./src/plugins/properties/bacon-video-widget-properties.c:
	parent_class = gtk_type_class (gtk_vbox_get_type ());


http://library.gnome.org/devel/gtk/unstable/gtk-Types.html#gtk-type-class
Note that this will require a gtk >= 2.14 dependency.
Comment 1 Philip Withnall 2009-02-17 00:06:27 UTC 
2009-02-17  Philip Withnall  <philip@tecnocode.co.uk>

	* src/plugins/properties/bacon-video-widget-properties.c
	(bacon_video_widget_properties_class_init),
	(bacon_video_widget_properties_init),
	(bacon_video_widget_properties_dispose): Tidy up
	BaconVideoWidgetProperties a little and remove a deprecated GTK+ call.
	(Closes: #572089)
Comment 2 André Klapper 2009-02-18 12:22:45 UTC 
Sorry, another one after also grep'ing for the stuff deprecated in gtk 2.15:

./src/totem-object.c:	gtk_action_connect_proxy (action, item);

http://library.gnome.org/devel/gtk/unstable/GtkAction.html#gtk-action-connect-proxy
Comment 3 Bastien Nocera 2009-02-18 13:24:19 UTC 
What's it supposed to be replaced by? The docs don't mention any replacement functions.
Comment 4 André Klapper 2009-02-18 13:29:11 UTC 
(In reply to comment #3)
> What's it supposed to be replaced by? The docs don't mention any replacement
> functions.

*shrug*
Maybe file a bug against the gtk API docs to provide better migration instructions (so we don't run into this question again and again for other modules), or ask on a mailing list...?
Comment 5 Philip Withnall 2009-02-18 14:26:58 UTC 
I'm wondering why I didn't get warned about this when compiling. As far as I can see, the flags $(DISABLE_DEPRECATED) are getting put in libtotem_main_la_CPPFLAGS correctly. :-\
Comment 7 Philip Withnall 2009-04-02 19:13:10 UTC 
2009-04-02  Philip Withnall  <philip@tecnocode.co.uk>

	* configure.in:
	* src/totem-object.c (totem_callback_connect): Remove our last
	deprecated GTK+ function call, bumping our GTK+ requirement to
	2.16.0. (Closes: #572089)