After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 569372 - 3D Ranges appear to be broken
3D Ranges appear to be broken
Status: RESOLVED OBSOLETE
Product: Gnumeric
Classification: Applications
Component: General
git master
Other All
: Normal major
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2009-01-27 18:39 UTC by Morten Welinder
Modified: 2018-05-22 13:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Initial patch (3.56 KB, patch)
2009-01-30 18:24 UTC, Morten Welinder
committed Details | Review

Description Morten Welinder 2009-01-27 18:39:20 UTC
The formula

    =vlookup(7,ThreeD1!C1:ThreeD2!D6,2)

gets evaluated as-if the middle range was just ThreeD1!C1:C6.

The expression gets parsed as a range ctor of ThreeD1!C1 and ThreeD2!D6.
Note, that gnm_expr_range_op never uses b_start.

Also, in this case the ranges are constant.  Do we really need dynamic
dependencies for this?  I would assume that we could simply create the
3D cell range as parse time.  (But note, that the ctor also is made on
xls import.)
Comment 1 Morten Welinder 2009-01-30 18:24:55 UTC
Created attachment 127565 [details] [review]
Initial patch

This patch constant-folds the range constructor at parse/load time.

Note: gnm_expr_range_op probably still needs attention -- not sure what.
Comment 2 Morten Welinder 2009-01-31 23:49:25 UTC
Initial patch is in.  We survive the tests...

Comment 3 Andreas J. Guelzow 2011-11-07 15:42:35 UTC
Anything still broken here?
Comment 4 GNOME Infrastructure Team 2018-05-22 13:31:22 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnumeric/issues/114.