After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 564820 - Search filter persists when changing folders
Search filter persists when changing folders
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.0.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[kill-bonobo]
: 643557 660900 693376 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-12-17 07:48 UTC by Mikel Ward
Modified: 2013-02-26 15:31 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
proposed evo patch (1.23 KB, patch)
2012-02-13 17:14 UTC, Milan Crha
committed Details | Review

Description Mikel Ward 2008-12-17 07:48:59 UTC
Please describe the problem:
A search filter in one folder is remembered when I change to another folder, but if it shows no results, I can't clear the filter.

Steps to reproduce:
1. Click on Inbox
2. Click in the Search filter box in the top right corner
3. Type something at the Sender or Recipients contain prompt that will match some messages in Inbox but not in Sent
4. Click on Sent



Actual results:
Message list displays "No message satisfies your search criteria. Either clear search with Search->Clear menu item or change it."

But Search->Clear and the Search filter box are both disabled.

Expected results:
Search->Clear works.  Clicking on the little broom (clear) icon in the Search filter box works.  Changing the criteria in the Search filter box works.

Or the filter is per-folder, so it defaults to empty when changing folders.

Does this happen every time?
Yes.

Other information:
Comment 1 Paul Bolle 2008-12-17 11:18:02 UTC
In 2.25 filters are per folder. Couldn't find the relevant ChangeLog item though. Maybe someone could provide a pointer to a relevant commit and/or just resolve this as FIXED.
Comment 2 Matthew Barnes 2008-12-17 13:26:49 UTC
Confirming.  I can reproduce this with 2.25.3.

Search results are only per folder when the scope is "Current Folder".  That hasn't changed recently.  Looks like the UI broke.

Clicking on a another folder SHOULD get you out of search results.  Looks like clicking on another folder in the same account doesn't, but clicking on another folder in a different account does.  That seems like the real bug here.


Tangentially, I sometimes question the value of per folder search results.  Especially when the UI doesn't make it clear whether you're looking at search results or the full folder contents (darkening the search entry box to indicate search results doesn't cut it).  Searching a folder, switching away, and switching back to that folder and seeing old search results still there is always a little surprising to me.

Nautilus does it better.  Do a search in Nautilus and check out the blue search results banner it gives you.  We need that.
Comment 3 Paul Bolle 2008-12-17 13:50:48 UTC
(In reply to comment #2)
> Confirming.  I can reproduce this with 2.25.3.
> 
> Search results are only per folder when the scope is "Current Folder".  That
> hasn't changed recently.

I'm missing something here. Could you please give an example of the kind of search that reproduces this behaviour?

> Looks like the UI broke.

That remarks is almost always correct! Note also that entering searches _for_ messages and entering searches _in_ a message share this UI. Looks bad to me. Terminology should also be split: better would be if one case would be "search" and the other case would be "find". Don't know which should be which.
Comment 4 Matthew Barnes 2008-12-17 17:35:41 UTC
(In reply to comment #3)
> I'm missing something here. Could you please give an example of the kind of
> search that reproduces this behaviour?

Not sure if this answers your question:

Search for "foo" in Inbox, then search for "bar" in Sent.  Switch between Inbox and Sent and you still see the search results for those folders.  Now switch to a different folder.  You should see the contents of that folder, not search results.

That Mikel is seeing the empty search results message in step 4 is the real bug.  He should be seeing the contents of the Sent folder.


> Note also that entering searches _for_ messages and entering searches _in_
> a message share this UI. Looks bad to me.

Agreed.  Not yet certain of the best way to fix that.
Comment 5 Milan Crha 2011-10-21 13:53:46 UTC
*** Bug 643557 has been marked as a duplicate of this bug. ***
Comment 6 Milan Crha 2011-10-21 13:53:59 UTC
*** Bug 660900 has been marked as a duplicate of this bug. ***
Comment 7 Milan Crha 2011-10-21 13:54:36 UTC
Setting version to 3.0.x, as the above duplicates are from that version.
Comment 8 Milan Crha 2012-02-10 14:50:48 UTC
Just wondering, is anybody able to reproduce this with 3.2.x or any later (development) version, please?
Comment 9 Milan Crha 2012-02-10 14:59:24 UTC
Just a side note: I have an idea on this: maybe, the message_list_set_folder() should clear both ml::search and ml::frozen_search, thus these will not be reused on regen. I do not know if it's it, but I would create a test patch if we have someone who can reproduce it and confirm whether it helps or not.
Comment 10 Adam Williamson 2012-02-11 06:12:42 UTC
I'm still seeing it, rather infrequently, but I've still never come up with a 100% reproducer.
Comment 11 Adam Williamson 2012-02-11 06:13:07 UTC
If you want to fix a bug, now, 646801 gets my vote. ;)
Comment 12 Milan Crha 2012-02-13 08:54:16 UTC
(In reply to comment #11)
> If you want to fix a bug, now, 646801 gets my vote. ;)

Hehe, bug #646801 is from a very very different pool of bugs :)
Comment 13 Milan Crha 2012-02-13 17:14:51 UTC
Created attachment 207467 [details] [review]
proposed evo patch

for evolution;

I guess this should make it. I'm not sure about the first part, but the second part is correct, it's for cases when you've set a search on an Inbox folder, and you move to a store node from it. Like when it's:
   On This Computer
       Inbox
and just pressing up arrow when moving from Inbox to On This Computer. The search entry is left filled with the values being used on the Inbox, though there is currently no folder selected. This is how I noticed this subissue.
Comment 14 Milan Crha 2012-04-23 10:52:37 UTC
Created commit e4cce2e in evo master (3.5.1+)
Created commit 9f5fd34 in evo gnome-3-4 (3.4.2+)
Comment 15 Milan Crha 2013-02-26 15:31:53 UTC
*** Bug 693376 has been marked as a duplicate of this bug. ***