GNOME Bugzilla – Bug 564766
File size should not be displayed under network icons
Last modified: 2012-09-10 13:02:03 UTC
Go to Places -> Network and increase the zoom to 150% or higher (or, alternatively, move "size" before "none" in the /apps/nautilus/icon_view/caption gconf entry) and notice that "0 bytes" is displayed below the name of each connection. This information should be hidden, as it is not relevant here.
Created attachment 222039 [details] screenshot
Created attachment 222052 [details] [review] Don't show "--" for unknown sizes just use a blank.
Created attachment 222053 [details] [review] Don't show captions that make no sense
Review of attachment 222053 [details] [review]: ::: src/nautilus-canvas-view-container.c @@ +374,3 @@ } + text = nautilus_file_get_string_attribute_with_default_q (file, attributes[i]); + if (text == NULL || text[0] == '\0' || strcmp (text, _("unknown")) == 0) { Relying on the translation of this string to be the same as the one in nautilus-file.c seems a little weak; at least, there should be a translator's comment both here and in the matching string in nautilus-file.c insisting the two strings should be translated identically. On the other hand, NautilusFile also has a nautilus_file_get_string_attribute() function, that avoids the "unknown" strings fallbacks. Maybe it would be a better choice to use that function here instead?
Review of attachment 222052 [details] [review]: Looks good, but if we can do what I suggested in the previous comment, this might be unnecessary.
Created attachment 222076 [details] [review] Don't show captions that make no sense
Review of attachment 222076 [details] [review]: Looks good.
*** Bug 109642 has been marked as a duplicate of this bug. ***