GNOME Bugzilla – Bug 562939
Pointers initialized to garbage instead of values set by XGetWindowProperty
Last modified: 2008-12-02 08:16:34 UTC
Please describe the problem: The fixes for -Wall made to src/core/iconcache.c in revision 4045 initialize the non-guchar pointers to garbage values instead of setting them to the values set by XGetWindowProperty. For example, in read_rgb_icon, data_as_long is set to whatever value happens to initially be in data, rather than what data is set to by XGetWindowProperty. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information: I'll attach a patch that fixes this issue shortly.
Created attachment 123774 [details] [review] Patch
I can't believe I wrote that :/ Committed with thanks.