After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 559081 - JPEG Save dialog preview should adjust size units
JPEG Save dialog preview should adjust size units
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
2.6.2
Other All
: Normal enhancement
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2008-11-03 11:30 UTC by Nils Philippsen
Modified: 2008-11-03 21:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to use MB as the jpeg preview unit for 1024 KB and higher (1.00 KB, patch)
2008-11-03 11:33 UTC, Nils Philippsen
none Details | Review

Description Nils Philippsen 2008-11-03 11:30:30 UTC
This was originally filed against Fedora at:
https://bugzilla.redhat.com/show_bug.cgi?id=469551

Description of problem:
When saving a JPEG and enabling 'Show preview' in the quality dialog, the file
size is always displayed in kB.  It would be nicer to switch to MB at 1024kB,
so that sizes can be directly compared with e.g. nautilus.

Version-Release number of selected component (if applicable):
gimp-2.4.7-3.fc9

How reproducible:
100%

Steps to Reproduce:
1.Start GIMP, open a large-ish image.
2.File->Save As...->foo.jpg
3.Enable preview
4.Inspect file size.

Actual results:
Shown in thousands of kB.

Expected results:
Shown in appropriate units.

Additional info:
Patch attached for gimp-2.6.2.
Comment 1 Nils Philippsen 2008-11-03 11:33:07 UTC
Created attachment 121857 [details] [review]
patch to use MB as the jpeg preview unit for 1024 KB and higher
Comment 2 Nils Philippsen 2008-11-03 11:33:39 UTC
NB: patch is by the original submitter, Tim Waugh.
Comment 3 Nils Philippsen 2008-11-03 11:37:39 UTC
Give me a shout if this should be made configurable, I imagine that some people would want to have the (more) exact KB numbers even for large files (e.g. when trying to satisfy space constraints).
Comment 4 Sven Neumann 2008-11-03 21:12:15 UTC
Thanks for spotting this. Fixed in trunk:

2008-11-03  Sven Neumann  <sven@gimp.org>

        Bug 559081 – JPEG Save dialog preview should adjust size units

        * plug-ins/file-jpeg/jpeg-save.c: use g_format_size_for_display()
        to display the JPEG file size.