After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 558058 - Metacity crashing with new GDM 2.24.
Metacity crashing with new GDM 2.24.
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.24.x
Other opensolaris
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2008-10-27 09:52 UTC by Brian Cameron
Modified: 2008-10-27 15:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch fixing crash issue (1.36 KB, patch)
2008-10-27 09:53 UTC, Brian Cameron
committed Details | Review

Description Brian Cameron 2008-10-27 09:52:34 UTC
On Solaris, I am seeing metacity crash when switching from the GDM session to the user session.  The attached patch fixes these problems.  It seems to be some issues with strcmp not handling NULL arguments properly.  Can this patch go upstream?
Comment 1 Brian Cameron 2008-10-27 09:53:18 UTC
Created attachment 121415 [details] [review]
patch fixing crash issue
Comment 2 Thomas Thurman 2008-10-27 11:55:22 UTC
Committed: http://svn.gnome.org/viewvc/metacity?rev=4003&view=rev

The fixes to ui.c were effectively already done in r4001 (http://svn.gnome.org/viewvc/metacity?rev=4003&view=rev) but I think an extra null check never hurt anyone.  I've also gone through and added checks in all the similar code paths in the other string handlers.

What changed in GDM to expose this, btw?  It ought only to happen when a key is expected but doesn't exist.
Comment 3 Thomas Thurman 2008-10-27 11:56:17 UTC
er, r4001 is http://svn.gnome.org/viewvc/metacity?rev=4001&view=rev of course.
Comment 4 Brian Cameron 2008-10-27 15:17:22 UTC
To be honest, I think what exposed this is that I had my "gdm" user's .gconf settings not set up properly.  Still, I thought it would be good to get these fixes upstream so that metacity doesn't crash when GConf isn't set up properly.

Thanks.