After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 555848 - Add introspection support
Add introspection support
Status: RESOLVED FIXED
Product: totem-pl-parser
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: totem-pl-parser-maint
totem-pl-parser-maint
Depends on:
Blocks: 585444
 
 
Reported: 2008-10-10 20:42 UTC by Philip Withnall
Modified: 2010-01-04 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Bug 555848 — Add introspection support (308.33 KB, patch)
2010-01-02 00:30 UTC, Philip Withnall
none Details | Review
Bug 555848 — Add introspection support (6.98 KB, patch)
2010-01-02 22:08 UTC, Philip Withnall
none Details | Review
Bug 555848 — Add introspection support (6.88 KB, patch)
2010-01-03 13:27 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2008-10-10 20:42:27 UTC
http://cgwalters.livejournal.com/21209.html

As per the above link, we should look into adding totem-pl-parser to the GIR repository. If this is going ahead, I'll be willing to handle it, including getting the introspection info into the GIR repo, and updating our gtk-doc comments with proper introspection annotation.

However, any work on this should probably wait until the end of next week at the earliest, to allow for any revelations at the Boston summit.
Comment 1 Bastien Nocera 2009-12-09 13:55:03 UTC
gnome-bluetooth has some examples on how it should be done.
Comment 2 Philip Withnall 2010-01-02 00:30:52 UTC
Created attachment 150658 [details] [review]
Bug 555848 — Add introspection support

Add complete introspection support to totem-pl-parser, including enough
annotations to ensure the GIR file is accurate. Closes: bgo#555848
Comment 3 Philip Withnall 2010-01-02 22:08:26 UTC
Created attachment 150706 [details] [review]
Bug 555848 — Add introspection support

Add complete introspection support to totem-pl-parser, including enough
annotations to ensure the GIR file is accurate. Closes: bgo#555848
Comment 4 Philip Withnall 2010-01-02 22:09:23 UTC
See bug #604770 for a way to do this without requiring introspection.m4 in tree (which is probably best, long-term). This is done in the updated patch.
Comment 5 Philip Withnall 2010-01-03 13:27:13 UTC
Created attachment 150730 [details] [review]
Bug 555848 — Add introspection support

Add complete introspection support to totem-pl-parser, including enough
annotations to ensure the GIR file is accurate. Closes: bgo#555848
Comment 6 Philip Withnall 2010-01-04 16:44:17 UTC
commit fa45f9b86eb1523e1ee981c6a2aeb28b0230bab5
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sat Jan 2 00:26:32 2010 +0000

    Bug 555848 — Add introspection support
    
    Add complete introspection support to totem-pl-parser, including enough
    annotations to ensure the GIR file is accurate. Closes: bgo#555848

 Makefile.am               |    4 ++-
 autogen.sh                |    1 +
 configure.in              |    3 +-
 plparse/Makefile.am       |   69 +++++++++++++++++++++++++++++++++++---------
 plparse/totem-disc.c      |    4 +-
 plparse/totem-pl-parser.c |   12 ++++----
 plparse/totem-pl-parser.h |    6 ++--
 7 files changed, 72 insertions(+), 27 deletions(-)

commit 067ef7123e389f071758712717c175c42c9af820
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Mon Jan 4 16:43:27 2010 +0000

    Add gtk-doc support for introspection annotations

 docs/reference/totem-pl-parser-docs.xml |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)