Bug 553980 – crash in Metacity: user logging in after 2....

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 553980 - crash in Metacity: user logging in after 2....


Summary:	crash in Metacity: user logging in after 2....


Status:	RESOLVED FIXED

Product:	metacity
Classification:	Other
Component:	general
Version:	unspecified
Hardware:	Other All

Importance:	High critical
Target Milestone:	---
Assigned To:	Metacity maintainers list
QA Contact:	Metacity maintainers list

URL:
Whiteboard:

Duplicates:	553981 563771 565875 570989 (view as bug list)
Depends on:
Blocks:

Reported:	2008-09-26 18:19 UTC by Joseph S. Atkinson
Modified:	2009-02-08 20:55 UTC

See Also:
GNOME target:	---
GNOME version:	2.23/2.24

Attachments
Prevent metacity from restarting after receiving a SIGTERM (1.30 KB, patch) 2008-10-08 16:21 UTC, Joe Marcus Clarke	committed	Details \| Review

Description Joseph S. Atkinson 2008-09-26 18:19:48 UTC

What were you doing when the application crashed?
user logging in after 2.24 upgrade


Distribution: Unknown
Gnome Release: 2.24.0 2008-09-24 (FreeBSD GNOME Project)
BugBuddy Version: 2.24.0

System: FreeBSD 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Fri Sep 26 12:06:13 EDT 2008     jsa@mephisto.wickedmachine.net:/usr/obj/usr/src/sys/MEPHISTO i386
X Vendor: The X.Org Foundation
X Vendor Release: 10402000
Selinux: No
Accessibility: Disabled
GTK+ Theme: (null)
Icon Theme: (null)

Memory status: size: 16384000 vsize: 16384000 resident: 10182656 share: 45584091 rss: 10182656 rss_rlim: 2486
CPU usage: start_time: 0 rtime: 0 utime: 0 stime: 0 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 133

Backtrace was generated from '/usr/local/bin/metacity'

[New Thread 8101140 (LWP 100115)]

+ Trace 207406

Thread 8101140 (LWP 100115)

#0 wait4
at wait4.S line 2
#1 __waitpid
at /usr/src/lib/libc/gen/waitpid.c line 46
#2 ___waitpid
at /usr/src/lib/libthr/thread/thr_syscalls.c line 586
#3 IA__g_spawn_sync
at gspawn.c line 382
#4 IA__g_spawn_command_line_sync
at gspawn.c line 694
#5 bugbuddy_segv_handle
at gnome-breakpad.cc line 229
#6 <signal handler called>
#7 meta_ui_parse_modifier
at ui/ui.c line 839
#8 mouse_button_mods_handler
at core/prefs.c line 1383
#9 meta_prefs_init
at core/prefs.c line 549
#10 main
at core/main.c line 395

Comment 1 Susana 2008-09-27 12:36:55 UTC

*** Bug 553981 has been marked as a duplicate of this bug. ***

Comment 2 Joe Marcus Clarke 2008-10-08 16:20:02 UTC

I see the same thing on FreeBSD.  What is happening is that gdm's metacity is crashing.  The reason for this is that metacity is sent a SIGTERM.  However, it's SM restart hint is set to SmRestartImmediately.  This causes it to be restarted.  Unfortunately, the underlying dbus socket has already been closed.  Therefore, GConf fails which leads to a NULL pointer dereference.

To fix this in FreeBSD, I added a SIGTERM handler which sets the SM restart hint to SmRestartIfRunning.  Basically, I'm just calling the standard metacity shutdown functions when a SIGTERM is delivered.  I'm not sure this is the right way of doing things, but it does keep gdm's metacity from restarting which prevents the crash.  Patch is attached.

Comment 3 Joe Marcus Clarke 2008-10-08 16:21:15 UTC

Created attachment 120202 [details] [review]
Prevent metacity from restarting after receiving a SIGTERM

Comment 4 palfrey 2008-12-29 01:55:40 UTC

*** Bug 563771 has been marked as a duplicate of this bug. ***

Comment 5 palfrey 2008-12-29 01:55:56 UTC

*** Bug 565875 has been marked as a duplicate of this bug. ***

Comment 6 Thomas Thurman 2009-01-25 22:41:47 UTC

This patch was already committed in r3974.

Comment 7 Gilles Dartiguelongue 2009-02-08 20:55:44 UTC

*** Bug 570989 has been marked as a duplicate of this bug. ***