After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552619 - File Chooser no longer automatically enters newly created directories
File Chooser no longer automatically enters newly created directories
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other Linux
: Normal major
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
: 563950 564307 568543 573199 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-09-17 10:46 UTC by iain
Modified: 2009-03-01 07:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
One-line patch against gtkfilechooserdefault.c in trunk (475 bytes, patch)
2009-02-27 10:51 UTC, Milan Bouchet-Valat
committed Details | Review

Description iain 2008-09-17 10:46:36 UTC
(Using SVN trunk r21408)

When creating a new folder with the file chooser the old behaviour used to be to automatically enter the new folder. This no longer happens, and it is necessary to search for the folder by hand and double click on it.
Comment 1 gg 2008-10-25 21:58:11 UTC
This may be intentional. Doing more than is asked for can be confusing rather than helpful. "Create new folder" should do just that and not move you elsewhere with a silent cd.

Since there is a fair chance your next move will be to move into the new folder and it may possibly not be visible in a long list, a helpful step would be to highlight the new dir in the file list pane.

This would give a rapid visual check that the name was what you intended it to be and means a click or Enter key takes you there.
Comment 2 Maciej Katafiasz 2008-12-03 19:11:49 UTC
This is a huge UI step backwards, there's absolutely no reason someone would create a directory in the FileChooser and not want to enter it, it's not a general file manager. Automatically entering the dir was one of the incredibly valuable touches that made the UI pleasant. Now the new dir usually ends off-screen and I have to fish for it manually. Bumping severity for the huge usability regression.
Comment 3 Matthias Clasen 2008-12-10 17:06:25 UTC
*** Bug 563950 has been marked as a duplicate of this bug. ***
Comment 4 Baptiste Mille-Mathias 2008-12-10 17:14:46 UTC
From my very humble opinion, I don't see why creating a folder should imply to open it, the suggestion in comment #1 to get the folder selected and visible in the list seems the right way to do, has we get the same behaviour than Nautilus.

CC'ing in the same time
Comment 5 Maciej Katafiasz 2008-12-14 02:44:59 UTC
Because entering it is the only reason you could ever want to create a folder from the FileChooser. Nautilus is a file manager, FileChooser isn't, it has no reason to create directories except to immediately choose them. Consistency here would be illusionary because they serve different purposes.
Comment 6 Michal Svoboda 2008-12-14 06:04:08 UTC
(In reply to comment #5)
> Because entering it is the only reason you could ever want to create a folder
> from the FileChooser.

Exactly. In fact, the whole purpose of that 'create new directory' button is such that you can quickly create a missing directory you wanna save a file to (as opposed to switching to your file manager, creating it there, going back to save dialog, hitting 'reload' or whatever and selecting the dir).
Comment 7 Baptiste Mille-Mathias 2009-01-21 13:01:30 UTC
*** Bug 568543 has been marked as a duplicate of this bug. ***
Comment 8 Saha Smirnovsky 2009-01-29 08:45:18 UTC
I have Ubuntu 8.10 x86_64 and the same situation with creating a folder with the file chooser. Please fix this bug.
Comment 9 mike lee 2009-02-20 00:20:39 UTC
I have the same problem here, when I tried to create new folder using file chooser in firefox. Please fix it.

Fedora 10
Comment 10 Nelson Benitez 2009-02-26 15:03:19 UTC
*** Bug 573199 has been marked as a duplicate of this bug. ***
Comment 11 Nelson Benitez 2009-02-26 15:19:22 UTC
From duplicate 573199 comment 2 :
Mac OS behavior has always been to immediately navigate inside the new folder,
on the grounds that if you create it then it's because that's where you want to
save the file.

Also, the previous behaviour (in gtk 2.12.9) was to automatically enter the new folder, that behaviour is already broken in gtk 2.14.0, so this bug is about fix a regression, not re-thinking gtk (already thought) behaviour.
Comment 12 Milan Bouchet-Valat 2009-02-27 10:49:26 UTC
I've just found the bug that had remove this nice feature. It's a if() condition that was set the wrong way and that should have always triggered an error dialog. But the error was null (obviously!) so the dialog was not shown, and the problem went unnoticed.

Attached is a one-line patch to fix this. Hope we can get this back ASAP, that's this kind of details that prompts you to think the file chooser is really smarter than you could expect! ;-)
Comment 13 Milan Bouchet-Valat 2009-02-27 10:51:13 UTC
Created attachment 129641 [details] [review]
One-line patch against gtkfilechooserdefault.c in trunk
Comment 14 Nelson Benitez 2009-02-27 12:13:32 UTC
(In reply to comment #13)
> Created an attachment (id=129641) [edit]
> One-line patch against gtkfilechooserdefault.c in trunk

 Thanks Milan!, I've tested the patch and works like a charm.

 The regression was introduced in the port of gtkfilechooser to GIO, in bug 520874 , so it first appeared in gtk-2.13.3 .

I'm looking forward to your patch to be commited.
Comment 15 Matthias Clasen 2009-02-27 14:36:01 UTC
Looks correct, thanks.
Comment 16 Federico Mena Quintero 2009-02-27 19:51:58 UTC
*** Bug 564307 has been marked as a duplicate of this bug. ***
Comment 17 Matthias Clasen 2009-03-01 07:33:53 UTC
        * gtk/gtkfilechooserdefault.c (edited_idle_cb): Switch to the newly
        created folder on success.