After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552577 - leaks GFileInfos
leaks GFileInfos
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: trash applet
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-17 02:40 UTC by Matthias Clasen
Modified: 2008-09-24 01:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (457 bytes, patch)
2008-09-17 02:41 UTC, Matthias Clasen 		reviewed Details | Review

Description Matthias Clasen 2008-09-17 02:40:43 UTC 
see attached patch
Comment 1 Matthias Clasen 2008-09-17 02:41:11 UTC 
Created attachment 118853 [details] [review]
patch
Comment 2 Callum McKenzie 2008-09-19 11:24:42 UTC 
I've asked the release team for a freeze-break so I can commit this.
Comment 3 Callum McKenzie 2008-09-21 20:19:43 UTC 
Approved and committed.
Comment 4 Sebastien Bacher 2008-09-23 16:07:52 UTC 
the new gnome-applets version crash for lot of users and that seems to be due to this change, see bug #553418
Comment 5 Sebastien Bacher 2008-09-23 16:17:46 UTC 
the change seems right, that's probably not it, the issue is new since the recente updates though, it could be due to libglib
Comment 6 Matthias Clasen 2008-09-23 17:29:16 UTC 
The problem seems to be that g_file_info_get_icon doesn't actually return a new reference. So the final g_object_unref (icon) is wrong.
Comment 7 Callum McKenzie 2008-09-24 01:20:31 UTC 
That is indeed the problem. The fix has been tested and applied to both trunk and gnome-2-24.