After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 549979 - move_to_center unimplemented
move_to_center unimplemented
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.22.x
Other All
: Normal enhancement
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2008-08-30 19:15 UTC by Khanh-Dang Nguyen Thu Lam
Modified: 2008-09-01 02:18 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
move_to_center (4.41 KB, patch)
2008-08-31 21:47 UTC, Thomas Thurman
none Details | Review
move_to_center (same again) (4.39 KB, patch)
2008-08-31 22:22 UTC, Thomas Thurman
committed Details | Review

Description Khanh-Dang Nguyen Thu Lam 2008-08-30 19:15:44 UTC
Keyboard shortcuts can be configured to move a window to sides or corners of the screen, e.g. by using:

$ gconftool-2 --type=string --set /apps/metacity/window_keybindings/move_to_side_n '<My>Shortcut'

However, the move_to_center is not implemented, neither in the 2.22.0 version I am running, nor in the latest development version. Indeed, in the src/core/keybindings.c source file, the function handle_move_to_center() is unimplemented.

Other information:
Comment 1 Thomas Thurman 2008-08-30 21:50:07 UTC
For the benefit of triage: are you saying that Metacity claims to be able to do move_to_center somewhere, and we don't do so (in which case this is a bug report about an unimplemented feature), or are you saying that Metacity doesn't claim to be able to do move_to_centre but it would be nice if it could (in which case this is an enhancement)?
Comment 2 Khanh-Dang Nguyen Thu Lam 2008-08-30 22:54:14 UTC
Sorry if I wasn't clear or if I misfilled the bug report. I was just requesting an enhancement. The move_to_* features are the only advanced features I actually need. I kind of miss the icewm's move_to_centre which I find very handy.

A move_to_centre feature would also enable the user to put a windows on one side, but centered, though with two keystrokes: move_to_centre followed by move_to_side_*.
Comment 3 Thomas Thurman 2008-08-30 23:52:41 UTC
Okay.  Seems like a reasonable request (any naysayers?)
Comment 4 Thomas Thurman 2008-08-31 21:47:34 UTC
Created attachment 117727 [details] [review]
move_to_center

Best I can tell, this works.  Does anyone (other than the reporter, obviously) have any opinions they'd like to share as to whether it should go in?
Comment 5 Thomas Thurman 2008-08-31 22:22:33 UTC
Created attachment 117731 [details] [review]
move_to_center (same again)

My mistake; got a flag backwards.  Showed up in further testing.
Comment 6 Thomas Thurman 2008-08-31 22:24:14 UTC
Reporter: Um, sorry, I'd like to hear your opinions as well: I just meant that presumably you thought we should add this feature :)
Comment 7 Khanh-Dang Nguyen Thu Lam 2008-09-01 00:49:41 UTC
Yeah, I've just run a freshly compiled metacity using your patch.  (Well, it took me quite a long time before I found out I had to install some gnome-specific tools in order to be able to compile metacity.)  All seems to work as expected.  Hope the patch is to be included in next release :)
Comment 8 Thomas Thurman 2008-09-01 02:18:31 UTC
Okay, committed in trunk.  Thank you!
Comment 9 Thomas Thurman 2008-09-01 02:18:48 UTC
( http://svn.gnome.org/viewvc/metacity?rev=3839&view=rev )