After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 545555 - LIRC missing default setup
LIRC missing default setup
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on: 540051 642299
Blocks: 545556
 
 
Reported: 2008-07-30 17:23 UTC by Bastien Nocera
Modified: 2011-02-14 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use a default lirc setup (4.14 KB, patch)
2008-07-30 17:25 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2008-07-30 17:23:25 UTC
See https://fedoraproject.org/wiki/Features/BetterLIRCSupport#User_Experience

Patch below
Comment 1 Bastien Nocera 2008-07-30 17:25:16 UTC
Created attachment 115574 [details] [review]
Use a default lirc setup
Comment 2 Jonathan Matthew 2008-07-30 21:46:22 UTC
Looks OK to me.  These bits seem to be sneaking in from a different patch, though:

-			rb_shell_player_seek (plugin->shell_player, 10);
+			rb_shell_player_seek (plugin->shell_player, FFWD_OFFSET);
 		} else if (strcmp (str, RB_IR_COMMAND_SEEK_BACKWARD) == 0) {
-			rb_shell_player_seek (plugin->shell_player, -10);
+			rb_shell_player_seek (plugin->shell_player, -RWD_OFFSET);

Comment 3 Bastien Nocera 2008-07-30 21:55:36 UTC
Yeah, it's from bug 540051
Comment 4 Bastien Nocera 2008-08-14 15:28:27 UTC
2008-08-14  Bastien Nocera  <hadess@hadess.net>

	* lib/rb-util.h:
	* plugins/lirc/Makefile.am:
	* plugins/lirc/rb-lirc-plugin.c (rb_lirc_plugin_read_code),
	(impl_activate):
	* plugins/lirc/rhythmbox_lirc_default: Add a default configuration
	for lirc, so that it works out-of-the-box (Closes: #545555)