After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 544347 - Removal of libgnomeui
Removal of libgnomeui
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
2.23.x
Other All
: Normal enhancement
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2008-07-23 13:48 UTC by James Sharpe
Modified: 2009-02-16 09:54 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Removes libgnomeui from g-s-d (1.85 KB, patch)
2008-07-23 13:49 UTC, James Sharpe
accepted-commit_now Details | Review
Fix after gnomeui removal (768 bytes, patch)
2008-07-25 15:00 UTC, Rob Bradford
none Details | Review

Description James Sharpe 2008-07-23 13:48:55 UTC
gnome-settings-daemon doesn't actually use any functionality from libgnomeui, only libgnome.

Attached patch removes libgnomeui.
Comment 1 James Sharpe 2008-07-23 13:49:41 UTC
Created attachment 115097 [details] [review]
Removes libgnomeui from g-s-d
Comment 2 Jens Granseuer 2008-07-24 17:19:58 UTC
Looks fine. Please commit.
Comment 3 James Sharpe 2008-07-24 19:38:54 UTC
Committed revision 402
Comment 4 Rob Bradford 2008-07-25 15:00:11 UTC
Created attachment 115253 [details] [review]
Fix after gnomeui removal

Whoopsie. This patch actually broke the build (I think your svn diff didn't enter the external'ed libsounds repository.)

I've made the fixes to libsounds and am about to commit the fix for gnome-settings-daemon (patch attached for reference.)
Comment 5 André Klapper 2009-02-15 23:42:31 UTC
I don't consider this fixed, hence REOPENing:

$:andre\> grep -r libgnomeui .
./plugins/xrandr/gsd-xrandr-manager.c:#include <libgnomeui/gnome-rr-config.h>
./plugins/xrandr/gsd-xrandr-manager.c:#include <libgnomeui/gnome-rr.h>
./plugins/xrandr/gsd-xrandr-manager.c:#include <libgnomeui/gnome-rr-labeler.h>
./plugins/background/gsd-background-manager.c:#include <libgnomeui/gnome-bg.h>
Comment 6 William Jon McCann 2009-02-16 04:16:04 UTC
Andre, that is gnome-desktop.
Comment 7 André Klapper 2009-02-16 09:54:50 UTC
sigh. Thanks for clarifying