GNOME Bugzilla – Bug 538822
Remove ephy-embed-find
Last modified: 2009-01-23 02:20:55 UTC
Make src/ use the webkit API directly.
Created attachment 112931 [details] [review] [PATCH] ephy-find-toolbar: port to use webkit API directly. Copy the code from embeb/webkit mostly verbatim for now. --- src/Makefile.am | 1 + src/ephy-find-toolbar.c | 173 ++++++++++++++++++++++++++++++++++------------ 2 files changed, 129 insertions(+), 45 deletions(-)
Created attachment 112932 [details] [review] [PATCH] embed: remove ephy-embed-find and the webkit implementation. embed/Makefile.am | 2 - embed/ephy-embed-factory.c | 6 -- embed/ephy-embed-find.c | 128 --------------------------- embed/ephy-embed-find.h | 101 --------------------- embed/webkit/Makefile.am | 2 - embed/webkit/webkit-embed-find.c | 179 -------------------------------------- embed/webkit/webkit-embed-find.h | 57 ------------ src/ephy-find-toolbar.c | 1 - 8 files changed, 0 insertions(+), 476 deletions(-)
EphyFindToolbar could use a few small cleanups still.
Created attachment 112940 [details] [review] [PATCH] ephy-find-toolbar: remove _EMBED_ from find results enum. src/ephy-find-toolbar.c | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-)
Created attachment 112941 [details] [review] [PATCH] ephy-find-toolbar: add FIXME about ge-search-key-press never being emitted. src/ephy-find-toolbar.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
Created attachment 112942 [details] [review] [PATCH] ephy-find-toolbar: M-x tabify src/ephy-find-toolbar.c | 56 +++++++++++++++++++++++----------------------- 1 files changed, 28 insertions(+), 28 deletions(-)
Created attachment 112943 [details] [review] [PATCH] ephy-find-toolbar: rename impl_* functions to ephy_find_toolbar_* src/ephy-find-toolbar.c | 38 +++++++++++++++++++------------------- 1 files changed, 19 insertions(+), 19 deletions(-)
Created attachment 112944 [details] [review] [PATCH] ephy-find-toolbar: remove $Id$ from license comment. CVS is long gone... --- src/ephy-find-toolbar.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
Created attachment 112945 [details] [review] [PATCH] ephy-find-toolbar: copy over embed scroll functionality. Only used here. --- src/ephy-find-toolbar.c | 57 +++++++++++++++++++++++++++++++++++++--------- 1 files changed, 46 insertions(+), 11 deletions(-)
Created attachment 112946 [details] [review] [PATCH] embed: remove scroll functions. embed/ephy-embed.c | 53 ------------------------------------------- embed/ephy-embed.h | 17 ------------- embed/webkit/webkit-embed.c | 31 ------------------------- 3 files changed, 0 insertions(+), 101 deletions(-)
Oh, there's one extension using scroll_by_pixels, so I guess we want to export that somehow. src/ephy-web-view-utils.c ?
I think if it's useful outside ephy, it should be in webkit-gtk's API.
Makes sense. Alp?
I've pushed everything but the removal of the scroll functions for now.
Opened upstream bug about the scrolling functions: https://bugs.webkit.org/show_bug.cgi?id=19802
Created attachment 113587 [details] [review] [1/1] ephy-find-toolbar: use upstream functions to scroll view. src/ephy-find-toolbar.c | 40 ++++------------------------------------ 1 files changed, 4 insertions(+), 36 deletions(-)
Commit these once the upstream API exists.
After several discussions with WebKit discussions it seems clear the way to go with this is to use the adjustment values directly. Committed with those changes.