After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 534319 - GLib's .pc files could use Libs.private
GLib's .pc files could use Libs.private
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.16.x
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2008-05-22 10:01 UTC by Tor Lillqvist
Modified: 2008-05-25 10:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Suggested patch (2.86 KB, patch)
2008-05-22 10:05 UTC, Tor Lillqvist
none Details | Review
Updated patch (2.86 KB, patch)
2008-05-22 13:38 UTC, Tor Lillqvist
committed Details | Review

Description Tor Lillqvist 2008-05-22 10:01:48 UTC
I think it would be more appropriate to have the INTLLIBS and ICONV_LIBS on a Libs.private line in glib-2.0.pc instead of the Libs line. The same for G_MODULE_LIBS in gmodule-2.0.pc.

G_THREAD_LIBS probably should stay on the Libs line though, as on some platforms all software that links to some library (i.e. libgthread) that uses threads might also need to link with the platform's thread-aware version of C library, or something like that.

In glib-2.0-uninstalled.pc, INTLLIBS and ICONV_LIBS presumably can be dropped completely, as it specifies the .la file anyway, and any required dependencies will be handled through that, won't they?
Comment 1 Tor Lillqvist 2008-05-22 10:05:12 UTC
Created attachment 111328 [details] [review]
Suggested patch

I admit this change might be risky, it might break something on some odd platform. And it will break build of software that has relied on implicitly being linked with INTLLIBS and haven't bothered specifying INTLLIBS in its Makefiles. (This will of course only be seen on platforms where INTLLIBS is non-empty.)

The current situation isn't broken as such... just slighly annoying. So feel free to resolve as WONTFIX if you think that is safest.
Comment 2 Owen Taylor 2008-05-22 13:27:07 UTC
gettext() and other libintl stuff is supposed to be usable without additional
libraries when you link against GLib, so INTLLIBS isn't Libs.private

iconv is wrapped within glib, so should be OK to make private.
Comment 3 Tor Lillqvist 2008-05-22 13:38:18 UTC
Created attachment 111337 [details] [review]
Updated patch

OK. Like this then?
Comment 4 Tor Lillqvist 2008-05-25 10:27:29 UTC
Patch committed to trunk (only).