After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 527132 - nautilus crash when making ftp connection
nautilus crash when making ftp connection
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.16.x
Other Solaris
: Normal normal
: ---
Assigned To: Alexander Larsson
gtkdev
Depends on:
Blocks:
 
 
Reported: 2008-04-09 13:07 UTC by padraig.obriain
Modified: 2008-04-09 15:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (681 bytes, patch)
2008-04-09 14:28 UTC, padraig.obriain
none Details | Review

Description padraig.obriain 2008-04-09 13:07:47 UTC
make firefox the default browser so that the GConf entry /desktop/gnome/url_handlers/ftp exists.

Then when attempting to make ftp connection in nautilus we get a crash:

# pstack nautilus.1206623789
core 'nautilus.1206623789' of 1350:     nautilus --sm-client-id 11819ce253000120662274200000011480002 --screen
-----------------  lwp# 1 / thread# 1  --------------------
 ff2460f0 strlen   (fe7e968f, ffbfe6a4, 0, 0, 0, 73) + 50
 ff2914e0 vsnprintf (ffbfe52f, 1, fe7e9678, ffbfe6a0, 7ffffc00, fffc00) + 64
 fe6d4b4c g_printf_string_upper_bound (fe7e9678, ffbfe6a0, 0, 0, ff367e80, 0) + 10
 fe7098d8 g_vasprintf (ffbfe5f4, fe7e9678, ffbfe6a0, 1, feec2a00, 0) + 68
 fe6edf38 g_strdup_vprintf (fe7e9678, ffbfe6a0, feec2a00, 0, 5, 1) + 10
 fe6edf68 g_strdup_printf (fe7e9678, 0, 42400, db4f0, fe773d74, fe7e9678) + 1c
 fe7c9f58 g_app_info_create_from_commandline (6ac938, 0, 2, 12800, 322bc, fe7fc15c) + bc
 f67a104c get_default_for_uri_scheme (f67a1168, 50b6f8, 6ac938, f67b120c, 1a9360, 50f988) + 198
 0012211c nautilus_mime_has_any_applications_for_file (29e0d0, 0, 4a56e0, 6d0d50, 0, 50b6f8) + 2c
 00078af8 nautilus_information_panel_update_buttons (2cd0c0, 148800, 51f508, 135f38, bc9, 0) + 90
 00078f44 nautilus_information_panel_set_uri (2cd0c0, 51f508, 6fbe48, 29e0d0, 78c00, 148c00) + 17c
 00078fb0 loading_uri_callback (6fbe48, 6aca50, 2cd0c0, ffbfeb28, 51dbc8, 78f98) + 18
 fe82f7c8 g_closure_invoke (0, 0, 2, ffbfeb28, ffbfe9bc, 51dbc8) + 1a8
 fe848390 signal_emit_unlocked_R (1, 1, fe870eb0, 8d, fe7760b8, fe7760a8) + 858
 fe8472b4 g_signal_emit_valist (2b7030, 201, ffbfeb40, ffbfeda0, 1daf88, fe870eb0) + 784
 fe847aac g_signal_emit_by_name (fe7760b0, 14d5e0, fe870eb0, 8d, 0, fe7760a8) + 4a0
 000950e8 location_has_really_changed (2b7030, 427d60, 2ac458, 40bfb0, 6ac988, 14d400) + ac
 000aaa40 finish_loading (427d60, 427d60, 0, c9eec, 1748fc, 427600) + 34
 000e0634 call_ready_callbacks_at_idle (1d7170, e05bc, 1d7170, 1d7180, feec2a00, 1d7180) + 78
 fe6c8d9c g_main_dispatch (1a3d08, 0, 0, 0, fe773d74, 1a3d10) + 1e0
 fe6ca440 g_main_context_dispatch (1, 1, fe7760a4, 2, fe7760a8, 1a3d08) + c8
 fe6ca960 g_main_context_iterate (1, 1, 1, 1a3d08, 11, 11) + 49c
 fe6cb264 g_main_loop_run (2011b8, 0, 0, 17cef0, 2011c0, 1) + 3e4
 feb26f5c gtk_main (0, 0, 0, bea0, fed710f8, 2011b8) + d8
 0007b8dc main     (0, ffbff29c, 0, 1a0858, 0, 149400) + 518
 00068f50 _start   (0, 0, 0, 0, 0, 0) + 108
-----------------  lwp# 8 / thread# 8  --------------------
 ff2c83f8 __lwp_park (2b14c8, 2afd88, f677bce0, 0, a0770, 2b14c8) + 14
 ff2c21ac cond_wait_queue (2b14c8, 2afd88, f677bce0, 3b9aca00, 2cbf42e0, 0) + 28
 ff2c25bc cond_wait_common (2b14c8, 2afd88, f677bce0, 0, 0, 0) + 298
 ff2c276c __cond_timedwait (2b14c8, 2afd88, f677be10, 0, 3, 0) + 50
 ff2c285c cond_timedwait (2b14c8, 2afd88, f677be10, ffffff, 17cfc8, 0) + 14
 ff2c289c pthread_cond_timedwait (2b14c8, 2afd88, f677be10, 1, f9de0a00, 0) + c
 fe621958 g_cond_timed_wait_posix_impl (2b14c8, 2afd88, 597e85c, 58c73d0, b748c, fe6336c0) + 14c
 fe69aaec g_async_queue_pop_intern_unlocked (2afbc8, 54, f677bed8, 60, 2b14c8, fe773d74) + 104
 fe6faec4 g_thread_pool_wait_for_new_task (201a08, 7a000, 1, 0, 1c00, 201a08) + a4
 fe6faefc g_thread_pool_thread_proxy (201a08, 0, ff367e00, fe773d74, 6ac9d8, 201a08) + 28
 fe6f9258 g_thread_create_proxy (5b33b0, fe776120, ff2c1440, fe7760e0, fe6faed4, fe776108) + 184
 ff2c8378 _lwp_start (0, 0, 0, 0, 0, 0)
Comment 1 padraig.obriain 2008-04-09 14:21:52 UTC
It looks like the problem is is gdesktopappinfo.c when info->name is being referenced before it is set.
Comment 2 padraig.obriain 2008-04-09 14:28:05 UTC
Created attachment 108928 [details] [review]
proposed patch
Comment 3 Matthias Clasen 2008-04-09 14:39:47 UTC
Nice catch, please commit to both branches.
Comment 4 padraig.obriain 2008-04-09 15:00:56 UTC
Done