After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 526796 - Wrong order of arguments in g_file_copy's fallback
Wrong order of arguments in g_file_copy's fallback
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal major
: ---
Assigned To: Christian Kellner
gtkdev
Depends on:
Blocks:
 
 
Reported: 2008-04-07 19:20 UTC by Christian Kellner
Modified: 2008-04-08 02:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix it! (455 bytes, patch)
2008-04-07 19:21 UTC, Christian Kellner
committed Details | Review

Description Christian Kellner 2008-04-07 19:20:45 UTC
We have mixed up argument ordering in g_file_copy's fallback code leading that even if you specify G_FILE_COPY_BACKUP, it will never be converted to make_backup in the g_file_replace () call.
Comment 1 Christian Kellner 2008-04-07 19:21:48 UTC
Created attachment 108801 [details] [review]
Fix it!
Comment 2 Matthias Clasen 2008-04-08 02:04:47 UTC
2008-04-07  Matthias Clasen  <mclasen@redhat.com>

        Bug 526796 – Wrong order of arguments in g_file_copy's fallback

        * gfile.c (file_copy_fallback): Fix the argument order. Patch
        by Christian Kellner.