GNOME Bugzilla – Bug 526139
Doesn't select CDDA source when autostarting
Last modified: 2008-04-11 10:49:00 UTC
When auto-launched from nautilus after an audio CD is inserted, Rhythmbox doesn't select the CD source as it should. A couple of problems: - desktop file doesn't say it can handle urls, so only local filenames are passed (which is why iPod autostart would work for example, as a local dirname is passed) - Playlist parsing in the shell drops unhandled results from totem-pl-parser, when we should at least try to find a source for the item - gnome-vfs and gvfs use different URLs for cdda. cdda:///dev/sr0 under gnome-vfs would be cdda://sr0/ under gvfs
Created attachment 108602 [details] [review] rb-gvfs-cdda-activation.patch
The last item can obviously be safely removed when the port to GIO is finished.
Patch looks OK to me. I think rb_shell_load_uri is getting a bit too complicated, but reworking it is a task for another day.
2008-04-11 Bastien Nocera <hadess@hadess.net> * data/rhythmbox.desktop.in.in: Say that we handle URLs, otherwise only local filenames are passed * plugins/audiocd/rb-audiocd-source.c (_gnome_vfs_to_gvfs_cdda_uri), (impl_want_uri): Handle new-style gvfs cdda URIs * shell/rb-shell.c (rb_shell_load_uri): When passing URIs that are ignored by the playlist parser, try to find a source that it could match. Fixes starting Rhythmbox from a CDDA nautilus window, or autostarted on insertion (Closes: #526139)