After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 522084 - GIcon support for GtkIconTheme & GtkImage
GIcon support for GtkIconTheme & GtkImage
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 520874
 
 
Reported: 2008-03-12 19:16 UTC by Alexander Larsson
Modified: 2008-05-27 05:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkImage and GtkIconTheme support for GIcon (26.73 KB, patch)
2008-03-12 19:19 UTC, Alexander Larsson 		committed Details | Review
patch on top of the other, fixes compiler warnings (623 bytes, patch)
2008-05-26 23:54 UTC, Carlos Garnacho 		committed Details | Review

Description Alexander Larsson 2008-03-12 19:16:46 UTC 
We want support for GIcon in at least GtkIconTheme and GtkImage.
Comment 1 Alexander Larsson 2008-03-12 19:19:13 UTC 
Created attachment 107170 [details] [review]
GtkImage and GtkIconTheme support for GIcon

Here is a patch that adds this. 
The Icon theme part was done by mclasen, the GtkImage part by me.
Comment 2 Christian Dywan 2008-05-25 16:54:30 UTC 
This looks quite nice. However after the change the file chooser doesn't use the "desktop" icon anymore but only a plain folder icon. I'm not quite sure what causes that.
Comment 3 Carlos Garnacho 2008-05-26 23:54:37 UTC 
Created attachment 111573 [details] [review]
patch on top of the other, fixes compiler warnings
Comment 4 Matthias Clasen 2008-05-27 05:23:46 UTC 
        Bug 522084 – GIcon support for GtkIconTheme & GtkImage

        * gtk/gtkicontheme.[hc]: Add support for GIcon based lookups.
        * gtk/gtkimage.[hc]: Allow setting an image from a GIcon.
        * gtk/gtk.symbols: Additions