After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 521851 - Redudant tests in gunixmounts.c
Redudant tests in gunixmounts.c
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.16.x
Other Linux
: Normal minor
: ---
Assigned To: Alexander Larsson
gtkdev
Depends on:
Blocks:
 
 
Reported: 2008-03-11 20:17 UTC by Josselin Mouette
Modified: 2008-03-14 11:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Proposed patch (1.38 KB, patch)
2008-03-11 20:17 UTC, Josselin Mouette
none Details | Review

Description Josselin Mouette 2008-03-11 20:17:31 UTC
In guess_mount_type, there are many redudant tests for guessing a CDROM drive. For example, if a string starts with "cdrom" it also starts with "cdr".
Comment 1 Josselin Mouette 2008-03-11 20:17:58 UTC
Created attachment 107089 [details] [review]
Proposed patch
Comment 2 Alexander Larsson 2008-03-14 11:16:01 UTC
commited to trunk