After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 519913 - gnome-python-extras uses system versions on test phase
gnome-python-extras uses system versions on test phase
Status: RESOLVED FIXED
Product: gnome-python-extras
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-02 14:56 UTC by Mart Raudsepp
Modified: 2008-03-02 23:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-python-extras-2.19.1-tests-sandboxing.patch (302 bytes, patch)
2008-03-02 15:20 UTC, Gilles Dartiguelongue
committed Details | Review

Description Mart Raudsepp 2008-03-02 14:56:05 UTC
gnome-python-extras 2.14 and 2.19 versions use the system version to do "make check", which is supposed to test the just compiled version, as seen at http://bugs.gentoo.org/show_bug.cgi?id=209846
Seems Makefile.am could be improved to be more like gnome-python-desktop does it, to get this fixed, as per the above reference gentoo bug comment #5
Comment 1 Gilles Dartiguelongue 2008-03-02 15:20:43 UTC
Created attachment 106391 [details] [review]
gnome-python-extras-2.19.1-tests-sandboxing.patch

patch to make Makefile.am similar to gnome-python-desktop.

This is not sufficient as I had to do this in the ebuild

    touch egg/recent/__init__.py
    touch egg/tray/__init__.py
    touch gtkmozembed/__init__.py
    touch gtkspell/__init__.py
    touch gdl/__init__.py
    touch gda/__init__.py
    touch gksu/__init__.py

to get it to successfully pass check phase. However, I think this is not appropriate given the following output:

Trying to import module gtkhtml2...  ok.
Trying to import module egg.trayicon...  not found
Trying to import module egg.recent...  ok.
Trying to import module gtkmozembed...  ok.
Trying to import module gtkspell...  ok.
Trying to import module gdl...  ok.
Trying to import module gda...  ok.
Trying to import module gksu...  not found
Trying to import module gksu.ui...  not found

while originally it was:
Trying to import module gtkhtml2...  ok.
Trying to import module egg.trayicon...  ok.
Trying to import module egg.recent...  ok.
Trying to import module gtkmozembed...  ok.
Trying to import module gtkspell...  ok.
Trying to import module gdl...  not found
Trying to import module gda...  not found
Trying to import module gksu...  not found
Trying to import module gksu.ui...  not found

it looks like nothing is done at all ?
Comment 2 Gustavo Carneiro 2008-03-02 22:41:26 UTC
The touches are not a correct fix; they simply create a dummy empty module.  Import works, but it's not importing the real modules.

Alas it's too hard to properly fix this, or i'm too lazy, so I only committed the patch.
Comment 3 Gilles Dartiguelongue 2008-03-02 23:21:14 UTC
the thing is the patch actually breaks the build in the limited environment of the ebuild which the dummy packages fixes. Afaics, some directory moving would be a start in fixing this.