After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 519344 - Don't use libgnome
Don't use libgnome
Status: RESOLVED FIXED
Product: gnome-scan
Classification: Other
Component: flegita
SVN HEAD
Other Linux
: Normal normal
: ---
Assigned To: Étienne Bersac
Étienne Bersac
Depends on:
Blocks:
 
 
Reported: 2008-02-28 17:46 UTC by Ross Burton
Modified: 2008-02-28 18:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.91 KB, patch)
2008-02-28 17:47 UTC, Ross Burton 		committed Details | Review

Description Ross Burton 2008-02-28 17:46:54 UTC 
Attaching a patch to remove libgnome from flegita, it's pointless.
Comment 1 Ross Burton 2008-02-28 17:47:07 UTC 
Created attachment 106177 [details] [review]
Patch
Comment 2 Étienne Bersac 2008-02-28 18:02:59 UTC 
Hi,

Without libgnome, the about dialog website url is not a button, there's not crash handling, etc. which make flegita smoother. I don't think it's pointless. I rather prefer a --disable-gnome option for XFCE guys (like in 0.4).

Regards,
Étienne.
Comment 3 Ross Burton 2008-02-28 18:13:52 UTC 
Crash handling doens't use libgnome now, so all you loose is a button.  And about six library dependencies.
Comment 4 Ross Burton 2008-02-28 18:16:47 UTC 
(and hopefully the new GTK+ can use gio to make it a button, always)
Comment 5 Étienne Bersac 2008-02-28 18:32:36 UTC 
Hi,

Ok, i commited the patch plus fixed a tiny bug that cause application name not to be translated.

Many thanks.
Étienne.