After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 518309 - Incorrect data*dir path in glib-gettextize output
Incorrect data*dir path in glib-gettextize output
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.18.x
Other Mac OS
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2008-02-23 21:32 UTC by Daniel Macks
Modified: 2012-06-07 15:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix order of datadir and datarootdir definitions (935 bytes, patch)
2012-06-07 02:49 UTC, Daniel Macks
committed Details | Review

Description Daniel Macks 2008-02-23 21:32:08 UTC
Running glib-gettextize from glib-2.14.6 (and back at least to 2.12.12) built into prefix=/sw on OS X 10.4 gives me:

Creating po/ subdirectory
Symlinking file mkinstalldirs
Symlinking file po/Makefile.in.in

Please add the files
  codeset.m4 gettext.m4 glibc21.m4 iconv.m4 isc-posix.m4 lcmessage.m4
  progtest.m4
from the /aclocal directory to your autoconf macro directory
or directly to your aclocal.m4 file.
You will also need config.guess and config.sub, which you can get from
ftp://ftp.gnu.org/pub/gnu/config/.

Bug: tells me to use "/aclocal" (coded as "$datadir/aclocal" in the script) instead of "/sw/share/aclocal" or whatever prefix-based location is appropriate. The bug is that glib-gettextize declares:

datadir=${datarootdir}
datarootdir=${prefix}/share

based on the glib-gettextize.in template:

datadir=@datadir@
datarootdir=@datarootdir@

but this is shell, not makefile, so $datarootdir is blank when it's used to define $datadir. Should instead be:

datarootdir=${prefix}/share
datadir=${datarootdir}

Those @datadir@ and @datarootdir@ values are the autoconf defaults, so should just switch them in the .in (i.e., if user is overriding with ./configure flags, he already knows what he's setting).
Comment 1 Daniel Macks 2008-09-25 06:28:13 UTC
ping. Still looks broken in 2.18.1
Comment 2 Daniel Macks 2012-06-07 02:49:23 UTC
Created attachment 215817 [details] [review]
Fix order of datadir and datarootdir definitions

Still broken in 2.32.3, here's a patch against git HEAD that fink has been using for several years.
Comment 3 Colin Walters 2012-06-07 11:00:20 UTC
Review of attachment 215817 [details] [review]:

Makes sense; I don't understand why we haven't been hitting this on Linux though.
Comment 5 Daniel Macks 2012-06-07 15:03:17 UTC
On a debian/weezy box with libglib2.0-2.32.3, it also emits "/aclocal" in the message despite having the files actually in being in /usr/share/aclocal. I guess nobody's actually read and tried to follow the instructions on linux:)