After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 510925 - gnome-settings-daemon doesn't propogate Xft settings
gnome-settings-daemon doesn't propogate Xft settings
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
2.21.x
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
: 509713 511221 511733 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-01-21 01:04 UTC by dynamotwain
Modified: 2008-01-25 19:12 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Patch to add HAVE_XFT2 back (691 bytes, patch)
2008-01-21 01:13 UTC, dynamotwain
committed Details | Review

Description dynamotwain 2008-01-21 01:04:07 UTC
Please describe the problem:
Upgrading to gnome-settings-daemon 2.21.5.2 caused all font sizes to increase by 30% because DPI settings listed in gconf aren't being exposed via the XSETTINGS protocol.

The source of this problem is the gdm/gnome-settings-daemon split. Running ./configure no longer defines HAVE_XFT2 in any circumstances, yet it's needed for the font rendering settings code in ./plugins/xsettings/gsd-xsettings-manager.c

Steps to reproduce:
1. Install gnome-settings-daemon-2.21.5.1
2. Compile freedesktop.org's xsettings reference implementation
3. Run xsettings-client


Actual results:
No Xft properties are being exposed via the XSETTINGS interface, causing control-center's font DPI setting to have no effect.

Expected results:


Does this happen every time?


Other information:
Comment 1 dynamotwain 2008-01-21 01:13:38 UTC
Created attachment 103293 [details] [review]
Patch to add HAVE_XFT2 back

Adds the check for libXft to define HAVE_XFT2 back, allowing users to override font DPI and subpixel rendering via control-center again.
Comment 2 Jens Granseuer 2008-01-22 16:03:18 UTC
*** Bug 511221 has been marked as a duplicate of this bug. ***
Comment 3 Jens Granseuer 2008-01-24 17:44:55 UTC
*** Bug 511733 has been marked as a duplicate of this bug. ***
Comment 4 Jens Granseuer 2008-01-24 21:04:50 UTC
*** Bug 509713 has been marked as a duplicate of this bug. ***
Comment 5 Michael Monreal 2008-01-25 11:51:24 UTC
Tested the patch and it solves the bug for me.
Comment 6 Cosimo Cecchi 2008-01-25 13:41:05 UTC
I tested it too and it works fine.
Comment 7 Jens Granseuer 2008-01-25 17:09:08 UTC
2008-01-25  Jens Granseuer  <jensgr@gmx.net>

        Patch by: <dynamotwain@aim.com>
                                      
        * configure.ac: readd check for XFT2 that got lost in the g-s-d split.
        Bug #510925.
Comment 8 Michael Monreal 2008-01-25 17:47:03 UTC
Anything went wrong here? I cannot compile trunk:

gsd-xsettings-manager.c: In function 'xft_settings_set_xresources':
gsd-xsettings-manager.c:481: error: 'old_locale' undeclared (first use in this function)
gsd-xsettings-manager.c:481: error: (Each undeclared identifier is reported only once
gsd-xsettings-manager.c:481: error: for each function it appears in.)
make[3]: *** [libxsettings_la-gsd-xsettings-manager.lo] Error 1
make[3]: Leaving directory `/home/nx/code/svn/gnome/gnome-settings-daemon/plugins/xsettings'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/nx/code/svn/gnome/gnome-settings-daemon/plugins'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nx/code/svn/gnome/gnome-settings-daemon'
make: *** [all] Error 2
Comment 9 Michael Monreal 2008-01-25 19:12:43 UTC
Sorry, unreleated. The checkin from bug #505470 is to blame.