After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 508537 - Rythmbox transcodes m4a files when copying to ipod
Rythmbox transcodes m4a files when copying to ipod
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: iPod
0.11.x
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-10 15:41 UTC by joss
Modified: 2008-06-11 21:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch which fixes the problem (994 bytes, patch)
2008-03-22 11:10 UTC, Shogun
none Details | Review

Description joss 2008-01-10 15:41:31 UTC
Please describe the problem:
I'm sure I've reported this before but I can't find it.  When copying songs to the ipod, Rhythmbox takes a lot longer than Banshee. Upon inspection, this is because it's transcoding them - the files are on the ipod are a different size to the original file.  The bug used to also rename the file to .mp3, but now the .m4a file type remains, but the track still appears to be messed with rather than simply copied.

Steps to reproduce:
1. Copy a .m4a file to an ipod
2. Compare the original file with the file on the ipod.
3. 


Actual results:


Expected results:
The track should be copied exactly.

Does this happen every time?
Yes

Other information:
Comment 1 Sebastien Bacher 2008-03-16 13:16:20 UTC
There is an ubuntu bug about that on https://bugs.launchpad.net/rhythmbox/+bug/164265
Comment 2 Shogun 2008-03-22 11:10:09 UTC
Created attachment 107790 [details] [review]
Patch which fixes the problem

I wrote a patch which fixes this bug. Tested on 0.11.5.

The problem was that codec audio/mpeg had higher priority than audio/aac, and that audio/x-m4a files were not recognized as audio/aac.

Hope this helps!
   Shogun
Comment 3 Christophe Fergeau 2008-04-08 13:04:35 UTC
The audio/x-m4a - audio/aac bit looks ok
As for the other part of the patch, rhythmbox shouldn't convert the m4a file at all whatever the order of the supported mime types list is (at least imo). Is it really doing that ?
Comment 4 Jonathan Matthew 2008-04-08 13:47:03 UTC
I'm pretty sure the other bit isn't necessary.  The encoder first checks if the type of the input file is in the list of acceptable output types, and only finds the first output type it can transcode to if that fails.
Comment 5 Christophe Fergeau 2008-04-08 14:15:57 UTC
Ok, thanks. At least it makes sense to favour m4a over mp3s on ipods (?) so that bit has its use as well
Comment 6 Christophe Fergeau 2008-06-11 21:44:37 UTC
K, I finally committed that patch in r5739, thanks :)