After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 504062 - Incorrect message list sorting: current view by sender
Incorrect message list sorting: current view by sender
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.22.x (obsolete)
Other All
: Normal minor
: ---
Assigned To: Milan Crha
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-12-17 15:36 UTC by Iñigo
Modified: 2008-03-11 10:21 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
Screenshot (162.58 KB, image/jpeg)
2007-12-17 15:43 UTC, Iñigo
  Details
proposed evo patch (1.89 KB, patch)
2008-01-24 13:04 UTC, Milan Crha
committed Details | Review

Description Iñigo 2007-12-17 15:36:14 UTC
Please describe the problem:
Sorting the main message view by sender returns a wrong sorting. It makes no difference to click on the Subject header or to choose it from Main Menu->Current View->By Sender.

Steps to reproduce:
1. Select message sorting by sender from Main Menu->Current View->By Sender
2. 
3. 


Actual results:
Message sorting is wrong.

Expected results:
Message sorting should be by sender field.

Does this happen every time?
Yes.

Other information:
Comment 1 Iñigo 2007-12-17 15:43:09 UTC
Created attachment 101128 [details]
Screenshot

Screenshot of message view wrongly orderer by sender.
Comment 2 André Klapper 2007-12-17 16:28:51 UTC
please click on the "From" column header.
Comment 3 Iñigo 2007-12-17 16:54:07 UTC
I checked both "From" and "Date" columns sorting and it returns the expected result. I checked it clicking on the header and also following the menu.
Comment 4 Baptiste Mille-Mathias 2007-12-18 18:45:35 UTC
Confirmed here also
Comment 5 Milan Crha 2008-01-15 14:19:45 UTC
Is it possible that this is only Fedora issue? In other words, which distro are you using?
Comment 6 Iñigo 2008-01-15 14:52:50 UTC
I don't know if it's a Fedora issue but I'm suspecting of it because I also opened another bug at the Fedora Bugzilla server and they just prompted me to check a new Evolution version, namely evolution-2.12.3-1.fc8.

BTW, this is the link to the filled bug:

https://bugzilla.redhat.com/show_bug.cgi?id=425980

I'll post any news from this new Evo version, if any.
Comment 7 Milan Crha 2008-01-15 15:13:17 UTC
BTW, that was me, whom pointed to that version. We had there some fix for other thing which touches related part of Evolution and I removed that patch in the version you mentioned above.

I only wonder if Baptiste Mille-Mathias has also Fedora or not. (And of course if the patch I removed really caused this issue).
Comment 8 Baptiste Mille-Mathias 2008-01-15 17:15:43 UTC
Hey there,

No, I'm using Hardy, ubuntu development version, and from I'm seing now, the bug is still valid
Comment 9 Milan Crha 2008-01-15 18:24:17 UTC
Hmm, it works for me on Evo from trunk (I guess they use this). Can you check if they have any patch touching evolution/mail/message-list.c:get_normalised_string function?
Comment 10 Iñigo 2008-01-16 15:47:42 UTC
I just tried evolution-2.12.3-1.fc8 and can confirm that the bug is still there :(
Comment 11 Milan Crha 2008-01-24 13:04:18 UTC
Created attachment 103630 [details] [review]
proposed evo patch

for evolution;

I guess it worked for me because of some coincidence with used strings.
The problem here was the "from/to" normalized strings has been compared as addresses, but the comparison was actually made on collate keys, which is obviously wrong. The thing with normalized subject was that there has been done comparisons based on collate, but again on collate keys, not the strings.
Both fixed and works for me now.
Comment 12 Srinivasa Ragavan 2008-01-27 10:18:10 UTC
Milan, seems fine to me. Commit to trunk.
Comment 13 Suman Manjunath 2008-01-28 06:26:55 UTC
Patch committed to SVN trunk as r34911
(http://svn.gnome.org/viewvc/evolution?view=revision&revision=34911)

so.. if indeed the addresses are not strhash'ed, the patch would fix the issue.. but I can't seem to figure out the logic behind using 'COL_*_NORM' for 'from/to' if they aren't actually normalised.. misnomer.. maybe even misleading.. 
Comment 14 Matthew Barnes 2008-03-11 00:36:52 UTC
Bumping version to a stable release.
Comment 15 Milan Crha 2008-03-11 10:21:14 UTC
Closing as fixed.
From/To "normalized" strings are not normalized, that's right, but they are stored in a e_poolv, so it consumes less memory. It's a bit confusing with terminology, but should be fine, I guess.