After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 502165 - Inconsistent toggle buttons are drawn unselected
Inconsistent toggle buttons are drawn unselected
Status: RESOLVED FIXED
Product: gtk-engines
Classification: Deprecated
Component: clearlooks
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-engines maintainers
gtk-engines maintainers
Depends on:
Blocks:
 
 
Reported: 2007-12-06 18:51 UTC by Vlada Peric
Modified: 2010-01-02 17:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot illustrating the bug; "thick" and "dashed" are in mixed state, while "thin" is unselected, but they appear the same. (3.06 KB, image/png)
2008-01-13 19:40 UTC, Vlada Peric
  Details
Mockup of 'mixed' style (2.46 KB, image/png)
2008-08-14 16:53 UTC, Calum Benson
  Details
patch implementing the suggestion from Calum (1.99 KB, patch)
2009-04-04 14:08 UTC, Benjamin Berg
none Details | Review

Description Vlada Peric 2007-12-06 18:51:12 UTC
Just as the summary says: the mixed state for a toggle button looks the same as the unselected state.
Comment 1 Thomas Wood 2008-01-13 17:43:15 UTC
If you could attach a screenshot to demonstrate the problem, that would be excellent.

Re-assigning to the gtk-engines product.
Comment 2 Vlada Peric 2008-01-13 19:40:39 UTC
Created attachment 102756 [details]
Screenshot illustrating the bug; "thick" and "dashed" are in mixed state, while "thin" is unselected, but they appear the same.

Screenshot attached; it may not be obvious, but the "Thick" and "Dashed" buttons are supposed to be in mixed-state, while the "Thin" button is unselected. 

Also, the bug was confirmed, so to say, by Calum Benson, maintainer of HIG. In fact, he told me to report it. Link (see 16:):
http://code.google.com/p/google-highly-open-participation-gnome/issues/detail?id=4#c9
Comment 3 Benjamin Berg 2008-01-13 21:52:32 UTC
Outch, the same problem probably also exist in other engines, this needs to be checked.

I don't have any idea of how we could draw the inconsistent state right now, though.
Comment 4 Calum Benson 2008-08-14 16:53:23 UTC
Created attachment 116587 [details]
Mockup of 'mixed' style

Had a quick play in GIMP with some ideas, this is about the best I could come up with.  (The middle button is supposed to represent the "mixed" state, of course.)
Comment 5 Benjamin Berg 2009-04-04 14:08:25 UTC
Created attachment 132075 [details] [review]
patch implementing the suggestion from Calum

Here is a simple patch that implements Calums suggestion. Andrea, do you think there is anything against commiting it?
Comment 6 Benjamin Berg 2010-01-02 15:13:20 UTC
OK, I committed the patch. If anyone dislikes this, please speak up (and suggest something better) :-)
Comment 7 Vlada Peric 2010-01-02 17:43:55 UTC
And to think it took a mere 2 years to fix this (including 8 months with a patch ready)!