After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 501362 - Possible typo in the theme parser
Possible typo in the theme parser
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: themes
trunk
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2007-12-03 20:55 UTC by Kjartan Maraas
Modified: 2007-12-09 19:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
patch to correct the typo (592 bytes, patch)
2007-12-06 01:22 UTC, Martin Meyer 		committed Details | Review

Description Kjartan Maraas 2007-12-03 20:55:26 UTC 
This code looks like it has a typo where tile_xoffset should really be tile_yoffset:

      /* These default to 0 */
      if (tile_xoffset && !check_expression (tile_xoffset, FALSE, info->theme, context, error))
        return;

      if (tile_yoffset && !check_expression (tile_xoffset, FALSE, info->theme, context, error))
        return;

This is around line 3185 in theme-parser.c
Comment 1 Elijah Newren 2007-12-04 01:35:40 UTC 
Nice catch.  :-)  Thomas: Can you verify, since you're in charge of the theme code?
Comment 2 Thomas Thurman 2007-12-04 02:30:32 UTC 
*nods* agreed on IRC earlier that this was an error. I can make the fix after I'm done with these dishes unless you want to, Kjartan.
Comment 3 Martin Meyer 2007-12-06 01:22:24 UTC 
Created attachment 100363 [details] [review]
patch to correct the typo

I know it was just a one-character patch, but I was bored and thought I'd send it over :-)
Comment 4 Thomas Thurman 2007-12-09 19:47:37 UTC 
Thanks for the patch :)

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.