After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 500533 - race condition on connection->msg_id (causing ID mismatch in sftp module)
race condition on connection->msg_id (causing ID mismatch in sftp module)
Status: RESOLVED WONTFIX
Product: gnome-vfs
Classification: Deprecated
Component: Module: ssh/sftp
2.20.x
Other All
: Normal major
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2007-11-29 22:36 UTC by Fabrice Bellet
Modified: 2018-08-17 13:49 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
proposed patch (924 bytes, patch)
2007-11-29 22:38 UTC, Fabrice Bellet
none Details | Review

Description Fabrice Bellet 2007-11-29 22:36:42 UTC
Please describe the problem:
I found a race condition for the access of conn->msg_id in sftp_connection_get_id(). This causes various ID mismatch errors when several threads share the same sftp connection. I think it occurs because get_file_info_for_path() is called without holding a lock from do_get_file_info_from_handle(). Patch follows.

Steps to reproduce:



Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Fabrice Bellet 2007-11-29 22:38:12 UTC
Created attachment 99868 [details] [review]
proposed patch
Comment 2 André Klapper 2018-08-17 13:49:19 UTC
gnome-vfs got deprecated in 2008.

gnome-vfs is not under active development anymore and had its last code changes
in 2011. Its codebase has been archived:
https://gitlab.gnome.org/Archive/gnome-vfs/commits/master

gio (in glib) and gvfs are its successors. See https://developer.gnome.org/gio/stable/ch33.html and https://people.gnome.org/~gicmo/gio-migration-guide/ for porting info.

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Feel free to open a task in GNOME Gitlab if the issue described in this task still applies to a recent + supported version of glib/gio/gvfs. Thanks!