GNOME Bugzilla – Bug 500533
race condition on connection->msg_id (causing ID mismatch in sftp module)
Last modified: 2018-08-17 13:49:19 UTC
Please describe the problem: I found a race condition for the access of conn->msg_id in sftp_connection_get_id(). This causes various ID mismatch errors when several threads share the same sftp connection. I think it occurs because get_file_info_for_path() is called without holding a lock from do_get_file_info_from_handle(). Patch follows. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 99868 [details] [review] proposed patch
gnome-vfs got deprecated in 2008. gnome-vfs is not under active development anymore and had its last code changes in 2011. Its codebase has been archived: https://gitlab.gnome.org/Archive/gnome-vfs/commits/master gio (in glib) and gvfs are its successors. See https://developer.gnome.org/gio/stable/ch33.html and https://people.gnome.org/~gicmo/gio-migration-guide/ for porting info. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Feel free to open a task in GNOME Gitlab if the issue described in this task still applies to a recent + supported version of glib/gio/gvfs. Thanks!