After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 494314 - GNOME_Evolution_Calendar_Cal leaked in e-data-cal-factory
GNOME_Evolution_Calendar_Cal leaked in e-data-cal-factory
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Calendar
2.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-11-06 21:24 UTC by Ondrej Jirman
Modified: 2013-09-14 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix for the bug (2.70 KB, patch)
2007-11-06 21:26 UTC, Ondrej Jirman
reviewed Details | Review
rebased patch with changelog entry (3.09 KB, patch)
2007-11-23 22:31 UTC, Ondrej Jirman
committed Details | Review

Description Ondrej Jirman 2007-11-06 21:24:30 UTC
If you look at the impl_CalFactory_getCal() you'll see that listener_copy is not used. Attached patch works for me so I guess it's just a leak.
Comment 1 Ondrej Jirman 2007-11-06 21:26:41 UTC
Created attachment 98681 [details] [review]
fix for the bug
Comment 2 Srinivasa Ragavan 2007-11-22 18:12:57 UTC
Milan, can you review this?
Comment 3 Milan Crha 2007-11-23 18:23:33 UTC
Sure srag, I can, but I do not know Bonobo or Corba much (read as "at all"), so it's just my opinion, no knowledge involved.

Ondrej, as usual, add here patch with ChangeLog entry and because of some recent changes in trunk, the patch doesn't apply smoothly, so let the new patch contains both data and ChangeLog entry. Thanks in advance.

Beside of this, it seems to me like working and makes sense. There is only one little tiny thing, I'm not sure why you didn't use BONOBO_OBJREF, you expanded this macro by yourself, instead (based on the documentation for this macro, at least).
Comment 4 Ondrej Jirman 2007-11-23 22:25:11 UTC
Actually that bonobo_object_corba_objref() call was inspired by similiar call in e-data-book-factory.c. I didn't know that macro exists.
Comment 5 Ondrej Jirman 2007-11-23 22:31:03 UTC
Created attachment 99558 [details] [review]
rebased patch with changelog entry
Comment 6 Milan Crha 2007-11-26 12:30:18 UTC
I do not see any difference between "before patch" and "after patch" so probably safe to commit to trunk. Btw, I didn't know about that macro too, I noticed it in a code you removed.
Comment 7 Milan Crha 2007-11-26 12:32:37 UTC
Committed to trunk. Committed revision 8245.
Comment 8 André Klapper 2007-12-30 22:32:56 UTC
ahoj milan & ondřej, seems like this commit introduced a crash.
please take a look at bug 506457! dĕkuji...