GNOME Bugzilla – Bug 494314
GNOME_Evolution_Calendar_Cal leaked in e-data-cal-factory
Last modified: 2013-09-14 16:49:59 UTC
If you look at the impl_CalFactory_getCal() you'll see that listener_copy is not used. Attached patch works for me so I guess it's just a leak.
Created attachment 98681 [details] [review] fix for the bug
Milan, can you review this?
Sure srag, I can, but I do not know Bonobo or Corba much (read as "at all"), so it's just my opinion, no knowledge involved. Ondrej, as usual, add here patch with ChangeLog entry and because of some recent changes in trunk, the patch doesn't apply smoothly, so let the new patch contains both data and ChangeLog entry. Thanks in advance. Beside of this, it seems to me like working and makes sense. There is only one little tiny thing, I'm not sure why you didn't use BONOBO_OBJREF, you expanded this macro by yourself, instead (based on the documentation for this macro, at least).
Actually that bonobo_object_corba_objref() call was inspired by similiar call in e-data-book-factory.c. I didn't know that macro exists.
Created attachment 99558 [details] [review] rebased patch with changelog entry
I do not see any difference between "before patch" and "after patch" so probably safe to commit to trunk. Btw, I didn't know about that macro too, I noticed it in a code you removed.
Committed to trunk. Committed revision 8245.
ahoj milan & ondřej, seems like this commit introduced a crash. please take a look at bug 506457! dĕkuji...