After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 488824 - get weather info when going online
get weather info when going online
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: gweather
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
: 154535 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-10-21 15:32 UTC by Matthias Clasen
Modified: 2008-11-11 08:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
the patch (3.11 KB, text/x-patch)
2007-10-21 15:35 UTC, Matthias Clasen
  Details
new patch (4.17 KB, patch)
2008-01-06 04:47 UTC, Matthias Clasen
none Details | Review

Description Matthias Clasen 2007-10-21 15:32:45 UTC
here is a quick patch to listen for NetworkManager online/offline status changes, and update the weather info when going online - it is very annoying that the weather applet sits for 30 minutes with the "unknown" icon on the panel even though I am online.
Comment 1 Matthias Clasen 2007-10-21 15:35:10 UTC
Created attachment 97559 [details]
the patch

Note that this patch adds a build dependency against NetworkManager, since it uses  the header files to get the right defines.
Comment 2 Allison Karlitskaya (desrt) 2007-10-22 18:24:26 UTC
the constants in your patch aren't in my version of networkmanager.

what version did you write this patch against?
Comment 3 Matthias Clasen 2007-10-22 21:45:52 UTC
Ah, you are right. The patch was written against the 0.7.0 snapshot that is shipping with Fedora 8. NM 0.7 will be released in a few weeks. It is probably possible to rewrite the patch in a way that makes it work with both 0.6.5 and 0.7,
using a different signal. I'll get back to you on that.
Comment 4 Matthias Clasen 2008-01-06 04:47:28 UTC
Created attachment 102257 [details] [review]
new patch

Finally redone the patch to work with NM 0.6
Comment 5 Dan Winship 2008-06-18 15:36:22 UTC
*** Bug 154535 has been marked as a duplicate of this bug. ***
Comment 6 Matthias Clasen 2008-11-09 18:30:29 UTC
Ping. Any chance to review the new patch ?
Comment 7 Callum McKenzie 2008-11-11 08:13:25 UTC
I've applied the patch and added the autoconf magic (I made NetworkManager  optional rather than a requirement).

I have the suspicion that things don't work out as well as they could if an update is already in progress (and stalled because the network has disappeared), but since this is probably an artifact of my short network-outages to test this, it is probably not a big issue.