After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 488298 - It displays "Draft (1)" when there is no message in Draft folder
It displays "Draft (1)" when there is no message in Draft folder
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.12.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Milan Crha
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-10-19 15:01 UTC by Milan Crha
Modified: 2008-05-27 14:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
proposed evo patch (3.57 KB, patch)
2007-10-22 11:02 UTC, Milan Crha
committed Details | Review

Description Milan Crha 2007-10-19 15:01:19 UTC
Forwarding from a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=201527

Steps to Reproduce:
1. Launch Mail-Evolution and create a new Mail Message
2. Click "Save Draft" on Toolbar and Close the "Compose Message" Window 
3. Click "Drafts" under "On This Computer" and "Junk" this draft message
4. Check "Drafts" and "Junk" folders
  
Actual results:
The message is saved in "Junk" folder, but "Drafts" folder displays "Drafts (1)"

Expected results:
When there is no messeage saved in Draft, it should be "Draft" instead of "Draft
(1)"
----------------------------------------------------------------------

I can reproduce it on actual Evolution (2.12.1), and main reason for this can be that the junk mails are always counted in Draft folders, even they are not "visible". Just a guess.
Comment 1 André Klapper 2007-10-19 17:42:17 UTC
classic problem with virtual folders, indeed. i think there's code for inbox to not count new junk mail - on the other hand, people should not be allowed to mark drafts as junk, we should just grey out the buttons! ;-)
Comment 2 Milan Crha 2007-10-22 11:02:37 UTC
Created attachment 97598 [details] [review]
proposed evo patch

for evolution;

It doesn't count junk messages in drafts and out box with this patch anymore. Also buttons for mark as junk and mark as not junk are not accessible in these folders.
Comment 3 Srinivasa Ragavan 2007-11-05 07:11:54 UTC
Milan, the patch looks fine to me. I haven't tested it. Just test and then commit it.
Comment 4 Milan Crha 2007-11-05 11:35:53 UTC
Committed to trunk. Committed revision 34502.
Comment 5 Srinivasa Ragavan 2008-05-16 11:26:49 UTC
Index: mail/em-folder-view.c
===================================================================
--- mail/em-folder-view.c	(revision 34402)
+++ mail/em-folder-view.c	(working copy)
@@ -182,7 +182,7 @@
 	{ "MessageMarkAsImportant",   EM_POPUP_SELECT_MANY|EM_POPUP_SELECT_MARK_IMPORTANT },
 	{ "MessageMarkAsUnimportant", EM_POPUP_SELECT_MANY|EM_POPUP_SELECT_MARK_UNIMPORTANT },
 	{ "MessageMarkAsJunk",        EM_POPUP_SELECT_MANY|EM_POPUP_SELECT_JUNK },
-	{ "MessageMarkAsNotJunk",     EM_POPUP_SELECT_MANY },
+	{ "MessageMarkAsNotJunk",     EM_POPUP_SELECT_MANY|EM_POPUP_SELECT_NOT_JUNK },
 	{ "MessageFollowUpFlag",      EM_POPUP_SELECT_MANY|EM_POPUP_SELECT_FLAG_FOLLOWUP },
 	{ "MessageFollowUpComplete",  EM_POPUP_SELECT_MANY|EM_POPUP_SELECT_FLAG_COMPLETED },
 	{ "MessageFollowUpClear",     EM_POPUP_SELECT_MANY|EM_POPUP_SELECT_FLAG_CLEAR },


This needs to be reverted. If not, you cant learn non junk mails. 
Comment 6 Srinivasa Ragavan 2008-05-27 14:03:16 UTC
I have fixed in stable/trunk some time back, but forgot to comment here.