GNOME Bugzilla – Bug 477045
Use standard icon names
Last modified: 2013-09-13 00:58:40 UTC
With the help of Federico's GtkIconCache logging patch [1], I made a focused effort to bring Evolution into compliance with the Icon Naming Specification [2]. Question for Srini: I was unsure of whether to replace "emblem-important" with "mail-mark-important". I personally think the emblem looks better for Evolution (at least with the Bluecurve theme), but obviously "mail-mark-important" is a better fit conceptually. [1] http://primates.ximian.com/~federico/news-2007-05.html#04 [2] http://standards.freedesktop.org/icon-naming-spec/latest/index.html
Created attachment 95608 [details] [review] Patch for Evolution
Gah, I forgot that Bonobo is brain-dead when it comes to icon names. I'll post a new patch when I get the xml files and E_PIXMAP stuff fixed up.
Created attachment 95644 [details] [review] Revised patch for Evolution This revision should work better. This is all going to be so much cleaner once we move to GtkUIManager...
Created attachment 95853 [details] [review] Revised patch for Evolution Smaller and saner revision that doesn't break dialog buttons.
Matthew, we should go with the mail-mark-imp* but if we feel that it isn't suited, lets get a hard step to make sure that it looks fine. (We gotto take this for the unread icon already). Lets not go for workaround/alternatives instead get them fixed/reworked.
Actually, "mail-unread" looks much better than "stock_mail-unread" (the stupid glasses are gone). But point taken. I'll prepare an update.
Created attachment 95920 [details] [review] Revised patch for Evolution This revision uses "mail-mark-important" instead of "emblem-important".
Matthew, I tried this patch and I dont see any obvious issues. So commit it to head. We should get it fast enough. The r-click on folder/book/cal/memo/tasks copy/paste uses a horrible icon. Cant we change it to be better? Matthew, I think we have to push the no attachment icon thingy to stable also.
Created attachment 96299 [details] Screenshot Srini, is this what you mean? Use standard icons for Copy and Properties? I haven't found a Paste item in the context menus. Another thing I noticed: Copy should have an ellipsis, Properties should not.
Patch committed to trunk (revision 34322).
*** Bug 468478 has been marked as a duplicate of this bug. ***
(In reply to comment #9) > Created an attachment (id=96299) [edit] > Screenshot > > Srini, is this what you mean? Use standard icons for Copy and Properties? I > haven't found a Paste item in the context menus. Yes. (Paste came on the flow :) > > Another thing I noticed: Copy should have an ellipsis, Properties should not. Go ahead. >
The icons for Copy and Move in the folder context menu kinda go together. Maybe we should leave this particular case alone -- at least until there's a standard icon name for Move -- but change the Copy icon in all the non-mailer context menus?
I think we can do it together.
I noticed 6 critical runtime warnings --- (evolution:26404): Gtk-CRITICAL **: gtk_image_get_pixbuf: assertion `image->storage_type == GTK_IMAGE_PIXBUF || image->storage_type == GTK_IMAGE_EMPTY' failed --- when opening message composer and as we settled with Matt on IRC, I looked what does it do. I found that it's that new code in e-msg-composer.c which you added together with structure entry_pixcache. When I remove this, it works just fine. I see a difference with icon size on toolbar with and without this change, but icons are same. (Those icons on toolbar are smaller when using code from trunk, probably because of those runtime warnings.)
Thanks Milan. I removed entry_pixcache from e-msg-composer.c.
Created attachment 96602 [details] [review] Another patch for Evolution Here's another patch that changes the Copy and Properties icons in the popup menus, as Srini and I discussed. I also changed the "mark-all-read" plugin icon to "mail-read".
Looks fine, Commit to head. I approved another patch for document-properties and just saw this.
Committed to Subversion trunk (revision 34354). I think it's safe to close this now.
When I right-click on the email address in preview panel of mail, then there is an item "Add to address book" which shows 'missing icon'. There is "edit-add", but may be rather "contact-new", I suppose.
Created attachment 96869 [details] [review] another proposed evo patch for evolution; Just fixing issue mentioned above.
Sounds fine to me.
Nice catch, Milan.
Committed to trunk. Committed revision 34363.