After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 477045 - Use standard icon names
Use standard icon names
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.12.x
Other Linux
: Normal normal
: ---
Assigned To: Matthew Barnes
Evolution QA team
: 468478 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-09-14 20:50 UTC by Matthew Barnes
Modified: 2013-09-13 00:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for Evolution (121.61 KB, patch)
2007-09-14 20:51 UTC, Matthew Barnes
needs-work Details | Review
Revised patch for Evolution (133.63 KB, patch)
2007-09-15 19:04 UTC, Matthew Barnes
none Details | Review
Revised patch for Evolution (95.99 KB, patch)
2007-09-19 14:45 UTC, Matthew Barnes
none Details | Review
Revised patch for Evolution (96.82 KB, patch)
2007-09-20 20:31 UTC, Matthew Barnes
committed Details | Review
Screenshot (37.30 KB, image/jpeg)
2007-09-27 16:48 UTC, Matthew Barnes
  Details
Another patch for Evolution (5.48 KB, patch)
2007-10-04 00:55 UTC, Matthew Barnes
committed Details | Review
another proposed evo patch (1.27 KB, patch)
2007-10-08 10:26 UTC, Milan Crha
committed Details | Review

Description Matthew Barnes 2007-09-14 20:50:34 UTC
With the help of Federico's GtkIconCache logging patch [1], I made a focused effort to bring Evolution into compliance with the Icon Naming Specification [2].

Question for Srini:

I was unsure of whether to replace "emblem-important" with "mail-mark-important".  I personally think the emblem looks better for Evolution (at least with the Bluecurve theme), but obviously "mail-mark-important" is a better fit conceptually.


[1] http://primates.ximian.com/~federico/news-2007-05.html#04
[2] http://standards.freedesktop.org/icon-naming-spec/latest/index.html
Comment 1 Matthew Barnes 2007-09-14 20:51:14 UTC
Created attachment 95608 [details] [review]
Patch for Evolution
Comment 2 Matthew Barnes 2007-09-15 04:17:27 UTC
Gah, I forgot that Bonobo is brain-dead when it comes to icon names.

I'll post a new patch when I get the xml files and E_PIXMAP stuff fixed up.
Comment 3 Matthew Barnes 2007-09-15 19:04:32 UTC
Created attachment 95644 [details] [review]
Revised patch for Evolution

This revision should work better.

This is all going to be so much cleaner once we move to GtkUIManager...
Comment 4 Matthew Barnes 2007-09-19 14:45:49 UTC
Created attachment 95853 [details] [review]
Revised patch for Evolution

Smaller and saner revision that doesn't break dialog buttons.
Comment 5 Srinivasa Ragavan 2007-09-20 19:26:08 UTC
Matthew, we should go with the mail-mark-imp* but if we feel that it isn't suited, lets get a hard step to make sure that it looks fine. (We gotto take this for the unread icon already). Lets not go for workaround/alternatives instead get them fixed/reworked. 
Comment 6 Matthew Barnes 2007-09-20 19:51:26 UTC
Actually, "mail-unread" looks much better than "stock_mail-unread" (the stupid glasses are gone).  But point taken.  I'll prepare an update.
Comment 7 Matthew Barnes 2007-09-20 20:31:36 UTC
Created attachment 95920 [details] [review]
Revised patch for Evolution

This revision uses "mail-mark-important" instead of "emblem-important".
Comment 8 Srinivasa Ragavan 2007-09-27 08:01:27 UTC
Matthew, I tried this patch and I dont see any obvious issues. So commit it to head. We should get it fast enough. The r-click on folder/book/cal/memo/tasks copy/paste uses a horrible icon. Cant we change it to be better?
 
Matthew, I think we have to push the no attachment icon thingy to stable also. 

Comment 9 Matthew Barnes 2007-09-27 16:48:53 UTC
Created attachment 96299 [details]
Screenshot

Srini, is this what you mean?  Use standard icons for Copy and Properties?  I haven't found a Paste item in the context menus.

Another thing I noticed: Copy should have an ellipsis, Properties should not.
Comment 10 Matthew Barnes 2007-09-27 17:51:37 UTC
Patch committed to trunk (revision 34322).
Comment 11 Matthew Barnes 2007-09-27 18:02:47 UTC
*** Bug 468478 has been marked as a duplicate of this bug. ***
Comment 12 Srinivasa Ragavan 2007-09-28 04:08:38 UTC
(In reply to comment #9)
> Created an attachment (id=96299) [edit]
> Screenshot
> 
> Srini, is this what you mean?  Use standard icons for Copy and Properties?  I
> haven't found a Paste item in the context menus.
Yes. (Paste came on the flow :)
> 
> Another thing I noticed: Copy should have an ellipsis, Properties should not.
Go ahead.
> 

Comment 13 Matthew Barnes 2007-09-28 04:50:24 UTC
The icons for Copy and Move in the folder context menu kinda go together.

Maybe we should leave this particular case alone -- at least until there's a standard icon name for Move -- but change the Copy icon in all the non-mailer context menus?
Comment 14 Srinivasa Ragavan 2007-09-28 05:10:31 UTC
I think we can do it together.
Comment 15 Milan Crha 2007-10-03 11:54:14 UTC
I noticed 6 critical runtime warnings
---
(evolution:26404): Gtk-CRITICAL **: gtk_image_get_pixbuf: assertion `image->storage_type == GTK_IMAGE_PIXBUF || image->storage_type == GTK_IMAGE_EMPTY' failed
---
when opening message composer and as we settled with Matt on IRC, I looked what does it do. I found that it's that new code in e-msg-composer.c which you added together with structure entry_pixcache. When I remove this, it works just fine. I see a difference with icon size on toolbar with and without this change, but icons are same. (Those icons on toolbar are smaller when using code from trunk, probably because of those runtime warnings.)
Comment 16 Matthew Barnes 2007-10-03 23:52:13 UTC
Thanks Milan.  I removed entry_pixcache from e-msg-composer.c.
Comment 17 Matthew Barnes 2007-10-04 00:55:19 UTC
Created attachment 96602 [details] [review]
Another patch for Evolution

Here's another patch that changes the Copy and Properties icons in the popup menus, as Srini and I discussed.  I also changed the "mark-all-read" plugin icon to "mail-read".
Comment 18 Srinivasa Ragavan 2007-10-04 08:18:59 UTC
Looks fine, Commit to head. I approved another patch for document-properties and just saw this. 
Comment 19 Matthew Barnes 2007-10-04 14:44:37 UTC
Committed to Subversion trunk (revision 34354).

I think it's safe to close this now.
Comment 20 Milan Crha 2007-10-08 10:14:12 UTC
When I right-click on the email address in preview panel of mail, then there is an item "Add to address book" which shows 'missing icon'. There is "edit-add", but may be rather "contact-new", I suppose.
Comment 21 Milan Crha 2007-10-08 10:26:27 UTC
Created attachment 96869 [details] [review]
another proposed evo patch

for evolution;
Just fixing issue mentioned above.
Comment 22 Srinivasa Ragavan 2007-10-08 18:07:45 UTC
Sounds fine to me.
Comment 23 Matthew Barnes 2007-10-08 18:58:37 UTC
Nice catch, Milan.
Comment 24 Milan Crha 2007-10-09 05:30:33 UTC
Committed to trunk. Committed revision 34363.