After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 476040 - gnome-icon-theme broke the attachment icon
gnome-icon-theme broke the attachment icon
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.12.x
Other Linux
: Normal critical
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 478888 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-09-11 22:50 UTC by Matthew Barnes
Modified: 2013-09-13 00:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (8.49 KB, patch)
2007-09-11 22:54 UTC, Matthew Barnes
committed Details | Review

Description Matthew Barnes 2007-09-11 22:50:56 UTC
So I just upgraded to the latest gnome-icon-theme and the "stock_attach" named icon is suddenly gone.  It's now called "mail-attachment".  The following patch makes Evolution use the newer icon.

I also changed the unknown attachment icon from "stock_unknown" to "mail-attachment", because I feel the following comment has been addressed:

   /* stock_attach would be better, but its fugly scaled up */
   pixbuf = e_icon_factory_get_icon("stock_unknown", E_ICON_SIZE_DIALOG);

I think the "mail-attachment" icon looks great scaled up (it's an SVG), but we can debate whether to switch the icon.

We should really commit at least the "stock_attach" to "mail-attachment" part of the patch for GNOME 2.20.  I personally don't think this constitutes a break in the UI freeze, since the attachment icon is broken anyway, but maybe it does.

Marking the severity as "critical" because we shouldn't ship Evolution 2.12.0 with such an obvious blemish.
Comment 1 Matthew Barnes 2007-09-11 22:54:19 UTC
Created attachment 95393 [details] [review]
Proposed patch

We can filter out the "stock_unknown"-to-"mail-attachment" hunks for the stable branch to avoid breaking the UI freeze.
Comment 2 sangu 2007-09-12 01:51:43 UTC
See Also :  https://bugzilla.redhat.com/show_bug.cgi?id=275771

When building gnome-icon-theme on icon-naming-utils-0.8.6, this problem is fixed, too.
Comment 3 Matthew Barnes 2007-09-12 03:02:01 UTC
Ah, thanks for pointing that out.  Perhaps we can leave this alone for GNOME 2.20 then and just commit the patch to trunk.
Comment 4 Matthew Barnes 2007-09-12 16:17:08 UTC
Srini gave me the go ahead on IRC to commit this to trunk (revision 34240).

The gnome-icon-theme issue sounds like a distro problem, not a GNOME problem, so closing this as FIXED.
Comment 5 Suman Manjunath 2007-09-21 20:02:29 UTC
*** Bug 478888 has been marked as a duplicate of this bug. ***