After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 470729 - Display screen position on the bars to the left and right
Display screen position on the bars to the left and right
Status: RESOLVED FIXED
Product: meld
Classification: Other
Component: general
1.1.x
Other Linux
: Low enhancement
: ---
Assigned To: Kai Willadsen
Stephen Kennedy
Depends on:
Blocks:
 
 
Reported: 2007-08-27 15:47 UTC by Vadim Peretokin
Modified: 2011-12-20 20:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Work-in-progress patch (26.66 KB, patch)
2008-09-09 13:52 UTC, Kai Willadsen
needs-work Details | Review

Description Vadim Peretokin 2007-08-27 15:47:48 UTC
Hello,

On the left and the right sides are displayed little colored lines that represent changes.

Would it be possible to have rectangles or somesuch track the position of the screen on those bars also?

Thank you, Meld is a really useful tool.
Comment 1 Stephen Kennedy 2007-08-27 20:15:14 UTC
The change blocks line up pretty well with the scrollbars. I wanted to draw the blocks inside the scrollbar gutter, but there was some pygtk api missing at the time. Perhaps that can be revisited.
Comment 2 Vadim Peretokin 2007-08-27 20:18:48 UTC
Hmm what I meant was something to track your position on the change blocks?

Right now, the scrollbars allow you to track your progress through the text file, but is it possible to have something that'll allow you to track progress through the change blocks.
Comment 3 Stephen Kennedy 2007-08-29 08:48:05 UTC
The top and the bottom of the scrollbar slider line up with the region of change   blocks you're currently viewing. Isn't that a coarse approximation of what you are looking for?
Comment 4 Vadim Peretokin 2007-08-29 12:35:03 UTC
Well yes it is. But do you think it would be possible to get an exact one? Low priority but it'd be really helpful :).
Comment 5 Kai Willadsen 2008-08-15 08:19:03 UTC
I have a private branch that does this, as well as making the change bars real GtkWidgets, porting the rendering to cairo and a few other small changes. Unfortunately, my development machine kicked the bucket recently, so while code exists, I can't current fix it for inclusion. If anyone else wants to work on this before I can get working again, I'll happily send code.
Comment 6 Stephen Kennedy 2008-09-04 08:49:01 UTC
On this, I had thought about putting the change bars into the gutter of the scrollbar. It saves some horizontal space, means the middle pane gets change bar in 3way and hopefully makes the relationship between the scrollbar/change bar more obvious.
Comment 7 Kai Willadsen 2008-09-09 11:19:22 UTC
Putting change bars in the scrollbar, apart from being a fair bit of work, could be really tricky to get right with different themeing, and might make the changes more difficult to see. Also, the scroll-handle will inevitably cover up the currently viewed area. On the other hand, it does save some space.

As for the change bar in 3-way... wouldn't you need *two* change bars if you wanted to add them to the middle pane?
Comment 8 Vadim Peretokin 2008-09-09 12:41:44 UTC
Even if it was just a black rectangle, that would be fine.

Because atm it's like a scrollbar without the thing you can press on to scroll. So you have no idea what is your position within a document.
Comment 9 Kai Willadsen 2008-09-09 13:52:44 UTC
Created attachment 118358 [details] [review]
Work-in-progress patch

Attaching a work-in-progress version of a patch which fixes this bug. It also provides more accurate offset calculations by taking into account borders, stepper sizing and other style properties of the scrollbars. In addition, it automatically adjusts to visibility of scrollbars within a gtk.ScrolledWindow, meaning that scrollbar visibility can be set to auto, fixing bug 540668.

There is still a lot of work to be done, including using style properties, coming up with nice defaults for colours, etc., and in general deciding whether the other visual changes I've made to the change bars are actually any good.
Comment 10 Kai Willadsen 2011-12-20 20:29:06 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.