After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 466497 - Should have differect mnemonics for Select button
Should have differect mnemonics for Select button
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.22.x (obsolete)
Other All
: Normal minor
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
aklapper[mnemonics] ghop[2007-14]
Depends on:
Blocks: 324810
 
 
Reported: 2007-08-14 06:01 UTC by Lucky Wankhede
Modified: 2013-09-13 00:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
Attaching screen shot for it.. (142.20 KB, image/png)
2007-08-14 06:03 UTC, Lucky Wankhede
  Details
Avoid using l as a mnemonic key (1.54 KB, patch)
2007-12-02 01:11 UTC, David Turner
needs-work Details | Review
Updated patch (2.01 KB, patch)
2007-12-03 19:27 UTC, David Turner
committed Details | Review

Description Lucky Wankhede 2007-08-14 06:01:20 UTC
"Preferences -> Mail Accounts -> IMAP -> Security -> "Encryption certificate" -> Select Button"

The mnemonics of select button is currently used 'l' narrow letter should be avoided in the mnemonics.. 

Go through the link.
http://developer.gnome.org/projects/gup/hig/2.0/input-keyboard.html#choosing-access-keys

I think 'S' can be used as it is not used in this screen.


Other information:
Comment 1 Lucky Wankhede 2007-08-14 06:03:02 UTC
Created attachment 93622 [details]
Attaching screen shot for it.. 

Screen shot of select button in preferences -> Account Editor -> IMAP -> Security.
Comment 2 David Turner 2007-12-02 01:11:14 UTC
Created attachment 100023 [details] [review]
Avoid using l as a mnemonic key

S was infact in use as a mnemonic key by "Digitally sign outgoing messages", so I changed that string to use "u" as the mnemonic and then used S for the select button.  "u" isn't a particularly obvious mnemonic, but it's certainly easier to see than "l".
Comment 3 André Klapper 2007-12-02 18:32:17 UTC
sounds reasonible
Comment 4 Milan Crha 2007-12-03 17:00:46 UTC
Please add bug reference to ChangeLog and make first Select button as "_Select" and second as "S_elect". I think that could be better have it opposite. Thanks.
Comment 5 David Turner 2007-12-03 19:27:10 UTC
Created attachment 100137 [details] [review]
Updated patch

New updated patch, stronger, faster, better than before.
(Not really, but I added a bug ref to the changelog and swapped the select button mnemonics like you asked).
Comment 6 Milan Crha 2007-12-04 12:31:20 UTC
Thanks, looks good to commit to trunk. (It's strange the widgets come in different order in file than in UI.)
Comment 7 Milan Crha 2007-12-04 12:32:21 UTC
Committed to trunk. Committed revision 34644.