After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 464131 - Allow inline view of application/mbox attachments
Allow inline view of application/mbox attachments
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.10.x (obsolete)
Other Linux
: Normal enhancement
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[attachments]
: 532987 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-08-06 20:16 UTC by Nicolas Trangez
Modified: 2009-06-21 03:52 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Proposed patch (3.27 KB, patch)
2009-06-15 20:01 UTC, Matthew Barnes
committed Details | Review

Description Nicolas Trangez 2007-08-06 20:16:10 UTC
As Git starts to be used frequently, on some development mailing lists patches are attached as RFC822-style text attachments to a normal email message, as git-format-patch generates patch files in this format. Currently it's not possible to view the content of these attachments inline in the email viewer, one can just save the attachment, whilst being able to view the patch inline would be very useful (and save a lot of time).
Comment 1 André Klapper 2007-08-08 15:39:37 UTC
what's the content type of such attachments set to?
Comment 2 Nicolas Trangez 2007-08-08 15:48:30 UTC
Seems to be application/mbox.

http://lists.freedesktop.org/archives/xorg/2007-August/027031.html is a sample mail (mailman interface to it, anyway). The UI gives me the opportunity to open the file in all text-editors installed on my system, but not inline.
Comment 3 Matthew Barnes 2009-06-15 15:51:09 UTC
*** Bug 532987 has been marked as a duplicate of this bug. ***
Comment 4 Matthew Barnes 2009-06-15 20:01:55 UTC
Created attachment 136660 [details] [review]
Proposed patch

Here's an initial cut at this.  It displays application/mbox attachments as a flat list of message/rfc822 parts.  Couple issues which we may or may not want to address up front (also noted in the patch):

  1) Should mbox's with multiple messages be converted to a multipart/digest
     so the messages can be expanded or collapsed individually?  Maybe mimic
     the logic in attachment_handler_mail_x_uid_list().

  2) Doesn't play well with other attachments.  Seems to want to create a
     second attachment bar containing all subsequent attachments, and screws
     up the attachment count in the top bar.  The x-evolution/message/rfc822
     handler is what's creating the unwanted attachment bar, but I suspect
     I'm doing something wrong in navigating the MIME part hierarchy.

Srini / Milan - Could either of you sanity check my approach?
Comment 5 Matthew Barnes 2009-06-15 20:19:31 UTC
(In reply to comment #4)
> Should mbox's with multiple messages be converted to a multipart/digest...

s/converted to/rendered as/

We wouldn't alter the original message, obviously.
Comment 6 Srinivasa Ragavan 2009-06-16 03:16:27 UTC
I just wont say anything apart from 'awesome' :-)

Lemme check up the second attachment bar. But, don't play apart from this file, as Im doing webkit rendering with the rest of the code. :-)