GNOME Bugzilla – Bug 464131
Allow inline view of application/mbox attachments
Last modified: 2009-06-21 03:52:23 UTC
As Git starts to be used frequently, on some development mailing lists patches are attached as RFC822-style text attachments to a normal email message, as git-format-patch generates patch files in this format. Currently it's not possible to view the content of these attachments inline in the email viewer, one can just save the attachment, whilst being able to view the patch inline would be very useful (and save a lot of time).
what's the content type of such attachments set to?
Seems to be application/mbox. http://lists.freedesktop.org/archives/xorg/2007-August/027031.html is a sample mail (mailman interface to it, anyway). The UI gives me the opportunity to open the file in all text-editors installed on my system, but not inline.
*** Bug 532987 has been marked as a duplicate of this bug. ***
Created attachment 136660 [details] [review] Proposed patch Here's an initial cut at this. It displays application/mbox attachments as a flat list of message/rfc822 parts. Couple issues which we may or may not want to address up front (also noted in the patch): 1) Should mbox's with multiple messages be converted to a multipart/digest so the messages can be expanded or collapsed individually? Maybe mimic the logic in attachment_handler_mail_x_uid_list(). 2) Doesn't play well with other attachments. Seems to want to create a second attachment bar containing all subsequent attachments, and screws up the attachment count in the top bar. The x-evolution/message/rfc822 handler is what's creating the unwanted attachment bar, but I suspect I'm doing something wrong in navigating the MIME part hierarchy. Srini / Milan - Could either of you sanity check my approach?
(In reply to comment #4) > Should mbox's with multiple messages be converted to a multipart/digest... s/converted to/rendered as/ We wouldn't alter the original message, obviously.
I just wont say anything apart from 'awesome' :-) Lemme check up the second attachment bar. But, don't play apart from this file, as Im doing webkit rendering with the rest of the code. :-)
Committed to master. http://git.gnome.org/cgit/evolution/commit/?id=c9e4c386ebfa2f561e817fefb09e43d1987213c6