After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 461805 - The combo cell renderer is broken theme wise
The combo cell renderer is broken theme wise
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
2.11.x
Other All
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
: 519410 (view as bug list)
Depends on: 521442
Blocks:
 
 
Reported: 2007-07-30 13:39 UTC by Alberto Ruiz
Modified: 2008-03-16 03:40 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
Combo cell renderer arrow (9.33 KB, image/png)
2007-07-30 13:41 UTC, Alberto Ruiz
  Details
The arrow still broken (24.90 KB, image/png)
2007-11-25 19:49 UTC, Alberto Ruiz
  Details
How combo arrows looks with the default xp theme (9.46 KB, image/png)
2007-11-25 19:51 UTC, Alberto Ruiz
  Details
How arrows looks with the classic windows theme on xp (4.21 KB, image/png)
2007-11-25 19:51 UTC, Alberto Ruiz
  Details
Gtk Combobox on Vista (364.75 KB, image/png)
2008-02-03 02:41 UTC, Cody Russell
  Details
Fixes for XP (1.32 KB, patch)
2008-03-08 07:18 UTC, Alberto Ruiz
none Details | Review
Fixes combobox child size allocation xthickness overriding (556 bytes, patch)
2008-03-09 18:43 UTC, Alberto Ruiz
none Details | Review
This patch fixes the classic theme (3.54 KB, patch)
2008-03-12 08:34 UTC, Alberto Ruiz
none Details | Review

Description Alberto Ruiz 2007-07-30 13:39:50 UTC
Please describe the problem:
The arrow box of the combo cell renderer is not properly sized to fit the row size.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Alberto Ruiz 2007-07-30 13:41:05 UTC
Created attachment 92702 [details]
Combo cell renderer arrow
Comment 2 Alberto Ruiz 2007-11-25 19:49:15 UTC
Created attachment 99628 [details]
The arrow still broken

This is how it looks with Gtk 2.12.

While the menu of the combo box looks nicer, the arrow is still broken.
Comment 3 Alberto Ruiz 2007-11-25 19:51:11 UTC
Created attachment 99629 [details]
How combo arrows looks with the default xp theme
Comment 4 Alberto Ruiz 2007-11-25 19:51:43 UTC
Created attachment 99630 [details]
How arrows looks with the classic windows theme on xp
Comment 5 Cody Russell 2008-02-03 02:41:44 UTC
Created attachment 104293 [details]
Gtk Combobox on Vista

I can't find a definitive reference for how they should look on Vista, but for reference here is what GtkComboBox looks like on Vista right now.
Comment 6 Alberto Ruiz 2008-03-08 07:18:18 UTC
Created attachment 106830 [details] [review]
Fixes for XP

At least, a patch that fixes the problem partially for XP. A damn frame was being drawn when it shouldn't. Also, the width of the button was incorrect, using correct system metrics now.
Comment 7 Alberto Ruiz 2008-03-08 16:43:58 UTC
Partially fixed in trunk and 2.12 (r19735 and r19734) respectively.

2008-03-08  Alberto Ruiz  <aruiz@gnome.org>

	* modules/engines/ms-windows/msw_style.c (draw_shadow):
	Do not draw frame if parent if combobox.
	(draw_box):
	Uses scrollbar width system metrics for combobox button.
	Fixes #461805 for XP theme engine.
Comment 8 Alberto Ruiz 2008-03-09 18:43:41 UTC
Created attachment 106924 [details] [review]
Fixes combobox child size allocation  xthickness overriding

gtk_combo_box_size_allocate was overriding x/y shadow thickness for the list mode.
Comment 9 Tor Lillqvist 2008-03-10 17:43:40 UTC
arc, bug #519410 looks like a duplicate of this, doesn't it? Although there are some additional oddities reported in that bug. 
Comment 10 Alberto Ruiz 2008-03-12 08:34:12 UTC
Created attachment 107125 [details] [review]
This patch fixes the classic theme

As soon as #521442 gets fixed, this patch would fix the issue.
Comment 11 Jody Goldberg 2008-03-12 23:41:18 UTC
*** Bug 519410 has been marked as a duplicate of this bug. ***
Comment 12 Alberto Ruiz 2008-03-16 03:39:58 UTC
Fixed in trunk, revision 19887

2008-03-16  Alberto Ruiz <aruiz@gnome.org>

        * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc:
        * modules/engines/ms-windows/msw_style.c (draw_box) (draw_arrow)
        (combo_box_draw_arrow) (setup_msw_rc_style): draw box does more intelligent
        separation for the xp theming engine and the classic theme while drawing the
        GtkComboBox button.
        combobox_draw_arrow is not used anymore, commented.
        The style has been updated to fix border/thickness glitches in the combobox
        according to the fixes commited regarding bug #521442. (bug #461805