After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 449118 - gnome-appearance-properties --show-page=fonts doesn't have an effect on gnome desktop.
gnome-appearance-properties --show-page=fonts doesn't have an effect on gnome...
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] settings-daemon
2.19.x
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-19 13:23 UTC by sangu
Modified: 2007-08-17 19:04 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
patch (5.13 KB, patch)
2007-06-20 01:26 UTC, Matthias Clasen
none Details | Review

Description sangu 2007-06-19 13:23:51 UTC
Please describe the problem:
gnome-appearance-properties --show-page=fonts doesn't have an effect on gnome desktop.

Steps to reproduce:
1.  $ gnome-appearance-properties --show-page=fonts
2.   Change font properties
3. 


Actual results:


Expected results:


Does this happen every time?
yes, always

Other information:
OS : Fedora Development ( rawhide 20070619)
control-center-2.19.4-1.fc8
Comment 1 Rodrigo Moya 2007-06-19 14:19:53 UTC
hmm, this works for me perfectly, are you sure you are using the latest 2.19.4? It seems so from the fedora package name, but not sure if it includes the very latest?
Comment 2 sangu 2007-06-19 14:40:50 UTC
(In reply to comment #1)
> hmm, this works for me perfectly, are you sure you are using the latest 2.19.4?
> It seems so from the fedora package name, but not sure if it includes the very
> latest?
> 

yes,  I sure that I install gnome-control-center 2.19.4 (package name control-center in fedora).

Additional information
After downgrading to gnome-control-center 2.19.3, this problem is fixed.

$rpm -Uhv control-center-2.19.3* --oldpackage
$killall -9 gnome-settings-daemon

fonts properties works well on gnome-appearance-properties.

But 
$rpm -Uhv control-center-2.19.4*
$killall -9 gnome-settings-daemon
gnome-appearace-properties --show-page=fonts doesn't work well.
font size, rendering and hinting become bad.
Comment 4 Jens Granseuer 2007-06-19 20:27:59 UTC
This sounds like a problem with gnome-settings-daemon, then. Is it only the font settings which have no effect? We've had similar reports for screensaver and themes as well (e.g. bug 448498).
Comment 5 Rodrigo Moya 2007-06-19 23:27:04 UTC
Ok, so I misunderstood the problem then, I thought it was about the --show-pag argument not working. It is indeed g-s-d's fault, my refactoring has added a few bugs I'm trying to fix now, which I'll commit soon.
Comment 6 Matthias Clasen 2007-06-20 01:26:49 UTC
Created attachment 90310 [details] [review]
patch
Comment 7 Matthias Clasen 2007-06-20 01:32:39 UTC
The problem is a (mis)use of a hashtable to store loaded modules in GnomeSettingsDaemon. One way to fix it would be to use g_direct_hash
and GINT_TO_POINTER for the keys, but it seems much more straightforward
to use an array of 4 lists for this, like the attached patch does.
Comment 8 Matthias Clasen 2007-07-10 15:46:18 UTC
Considering the low number of services here, let me propose to 
be even more radical and go with a single list of services.
Comment 9 Rodrigo Moya 2007-07-11 10:18:13 UTC
Right, make sense, could you please provide the patch with a ChangeLog entry? Attach it here and commit directly, please.
Comment 10 Jens Granseuer 2007-08-17 19:04:51 UTC
2007-08-17  Jens Granseuer  <jensgr@gmx.net>
                                           
        * gnome-settings-daemon.c: (initialize_modules), (start_modules),
        (stop_modules), (finalize), (gnome_settings_daemon_init),
        (gnome_settings_daemon_new): use a list instead of a hash table to
        store the settings modules (closes bug #449118)