GNOME Bugzilla – Bug 449118
gnome-appearance-properties --show-page=fonts doesn't have an effect on gnome desktop.
Last modified: 2007-08-17 19:04:51 UTC
Please describe the problem: gnome-appearance-properties --show-page=fonts doesn't have an effect on gnome desktop. Steps to reproduce: 1. $ gnome-appearance-properties --show-page=fonts 2. Change font properties 3. Actual results: Expected results: Does this happen every time? yes, always Other information: OS : Fedora Development ( rawhide 20070619) control-center-2.19.4-1.fc8
hmm, this works for me perfectly, are you sure you are using the latest 2.19.4? It seems so from the fedora package name, but not sure if it includes the very latest?
(In reply to comment #1) > hmm, this works for me perfectly, are you sure you are using the latest 2.19.4? > It seems so from the fedora package name, but not sure if it includes the very > latest? > yes, I sure that I install gnome-control-center 2.19.4 (package name control-center in fedora). Additional information After downgrading to gnome-control-center 2.19.3, this problem is fixed. $rpm -Uhv control-center-2.19.3* --oldpackage $killall -9 gnome-settings-daemon fonts properties works well on gnome-appearance-properties. But $rpm -Uhv control-center-2.19.4* $killall -9 gnome-settings-daemon gnome-appearace-properties --show-page=fonts doesn't work well. font size, rendering and hinting become bad.
See Also : https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244843
This sounds like a problem with gnome-settings-daemon, then. Is it only the font settings which have no effect? We've had similar reports for screensaver and themes as well (e.g. bug 448498).
Ok, so I misunderstood the problem then, I thought it was about the --show-pag argument not working. It is indeed g-s-d's fault, my refactoring has added a few bugs I'm trying to fix now, which I'll commit soon.
Created attachment 90310 [details] [review] patch
The problem is a (mis)use of a hashtable to store loaded modules in GnomeSettingsDaemon. One way to fix it would be to use g_direct_hash and GINT_TO_POINTER for the keys, but it seems much more straightforward to use an array of 4 lists for this, like the attached patch does.
Considering the low number of services here, let me propose to be even more radical and go with a single list of services.
Right, make sense, could you please provide the patch with a ChangeLog entry? Attach it here and commit directly, please.
2007-08-17 Jens Granseuer <jensgr@gmx.net> * gnome-settings-daemon.c: (initialize_modules), (start_modules), (stop_modules), (finalize), (gnome_settings_daemon_init), (gnome_settings_daemon_new): use a list instead of a hash table to store the settings modules (closes bug #449118)