After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 426083 - Show cover when available
Show cover when available
Status: RESOLVED OBSOLETE
Product: totem
Classification: Core
Component: Properties page
unspecified
Other All
: Normal enhancement
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on: 318748
Blocks:
 
 
Reported: 2007-04-04 00:50 UTC by Reviczky Ádám János
Modified: 2018-05-24 10:29 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
patch for this bug (5.35 KB, patch)
2009-01-31 15:09 UTC, Maxim Ermilov
needs-work Details | Review
screenshot (26.69 KB, image/png)
2009-01-31 15:14 UTC, Maxim Ermilov
  Details
corrected patch (7.23 KB, patch)
2009-02-11 17:31 UTC, Maxim Ermilov
none Details | Review
Half updated patch (8.03 KB, patch)
2009-04-02 23:43 UTC, Bastien Nocera
needs-work Details | Review

Description Reviczky Ádám János 2007-04-04 00:50:07 UTC
Add some matroska infos for the properties tab in nautilus:
Cover, Attachements, Tags, Chapters, etc.
See the windows shell extension here: http://www.matroska.org/downloads/shellextension/index.html
Comment 1 Reviczky Ádám János 2007-04-04 00:53:41 UTC
it depends partially on bug #318748: http://bugzilla.gnome.org/show_bug.cgi?id=318748
Comment 2 Bastien Nocera 2007-04-04 00:55:10 UTC
I'm afraid that I won't be adding any matroska specific items to the fold, although having covers show up would be nice. Problem is the same as in bug 318748.
Comment 3 Reviczky Ádám János 2007-04-04 00:58:15 UTC
Ok, but is there another place for supporting such things (fill a bug against)?
Comment 4 Bastien Nocera 2007-04-04 01:03:32 UTC
How about the matroska project itself? I'm sure creating such a property window would be straight forward with their libraries.
Comment 5 Bastien Nocera 2008-06-10 21:21:56 UTC
Showing the cover should be dead-easy to implement. The code and interface are in src/plugins/properties/, and you can use test-properties-page in src/ to test your changes.
Comment 6 Bastien Nocera 2008-12-08 15:12:45 UTC
You'd need to use BVW_INFO_COVER to get the cover art if it's available.
Comment 7 Maxim Ermilov 2009-01-31 15:09:03 UTC
Created attachment 127626 [details] [review]
patch for this bug
Comment 8 Maxim Ermilov 2009-01-31 15:14:16 UTC
Created attachment 127628 [details]
screenshot
Comment 9 Bastien Nocera 2009-02-09 18:04:18 UTC
I'd rather not see "Cover:" at all if the file doesn't provide one. Also, if you're going to resize the cover to 50x50 (why 50x50?) please provide a way to see the full cover when it's clicked on. Finally "Cover:" should be top-aligned, not center-aligned.
Comment 10 Maxim Ermilov 2009-02-11 17:31:47 UTC
Created attachment 128483 [details] [review]
corrected patch

"Cover:" doesn't show if the file doesn't provide one. Cover image now has dynamic size. when cover's clicked on, open new dialog with real size image.
Comment 11 Bastien Nocera 2009-04-02 23:43:31 UTC
Created attachment 131956 [details] [review]
Half updated patch

Here's (half of) my take on how it should work.

- Small cover (50px max in height and width) in a button with no relief
- When the button is clicked, show a popup with a bigger (or much bigger) image
- Popup goes away when button is released

Popup placement should be centered on the original, so that it looks like we "zoomed" into it. Bit more work needed I'm afraid.

Thanks for working on that.
Comment 12 GNOME Infrastructure Team 2018-05-24 10:29:39 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/totem/issues/11.