After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 424639 - weather applet preferences find function doesn't work well with multiple matches
weather applet preferences find function doesn't work well with multiple matches
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: gweather
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
: 539152 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-03-30 21:07 UTC by Ray Strode [halfline]
Modified: 2010-04-23 08:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a patch that seems to fix things (633 bytes, patch)
2007-03-30 21:10 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2007-03-30 21:07:33 UTC 
If you type "Barcelona" into the find entry then it will take you to Barcelona, Venezuela.  That's okay (although not ideal), but clicking "Find Next" doesn't jump to the next entry (the "Barcelona/Airport", the one in Spain).

More details available downstream here:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209488
Comment 1 Ray Strode [halfline] 2007-03-30 21:10:51 UTC 
Created attachment 85594 [details] [review]
a patch that seems to fix things

It looks like the problem is the code only looks at the direct parent of the first match when searching for the second match.  Since there aren't any more countries in Central America after Venezuela the search stops.
Comment 2 Sebastien Bacher 2007-05-15 21:52:11 UTC 
Ubuntu bug on https://bugs.launchpad.net/gnome-applets/+bug/113493
Comment 3 Pacho Ramos 2008-07-05 18:11:35 UTC 
Works fine for me under Gentoo, please apply it! 

Thanks :-)
Comment 4 Matthias Clasen 2009-01-06 18:12:35 UTC 
We ship this patch in Fedora, too
Comment 5 Philip Withnall 2009-07-08 09:53:37 UTC 
*** Bug 539152 has been marked as a duplicate of this bug. ***
Comment 6 Pacho Ramos 2009-10-16 18:34:51 UTC 
Why is this patch still not applied? It would be great to finally solve this in upstream

Thanks a lot :-)
Comment 7 James 2009-10-16 18:52:47 UTC 
The patch works great, why hasn't it been applied yet?
Comment 9 Pacho Ramos 2009-10-17 09:56:08 UTC 
Thanks a lot :-D
Comment 10 Pacho Ramos 2010-04-23 08:34:00 UTC 
(In reply to comment #8)
> Review of attachment 85594 [details] [review]:
> 
> Commited now:
> 
> http://git.gnome.org/cgit/gnome-applets/commit/?id=330dd851f79521b0340ab7b7bea559f1ec9ee7e2

I don't know why this patch no longer works with 2.28 and 2.16 :-( (I cannot try 2.30 just now)