After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 410684 - [artdisplay] support getting cover art from musicbrainz
[artdisplay] support getting cover art from musicbrainz
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
HEAD
Other Linux
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on: 410681
Blocks: 412853
 
 
Reported: 2007-02-22 05:37 UTC by Alex Lancaster
Modified: 2009-08-29 10:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
New MusicBrainzCoverArtSearch class (3.68 KB, patch)
2007-03-04 14:15 UTC, Alex Lancaster
none Details | Review
Improve error checking (4.09 KB, patch)
2007-03-04 14:50 UTC, Alex Lancaster
none Details | Review
updated, simplified a bit (3.85 KB, patch)
2007-08-25 10:48 UTC, Jonathan Matthew
needs-work Details | Review

Description Alex Lancaster 2007-02-22 05:37:25 UTC
If a track has musicbrainz information (either in a file or rhythmdb) it should pull cover art from amazon-via-musicbrainz since it is more reliable than the bare-bones amazon search.  Depends on bug #410681.
Comment 1 Alex Lancaster 2007-03-04 14:15:53 UTC
Created attachment 83889 [details] [review]
New MusicBrainzCoverArtSearch class

This is a first-cut approach that requires the installation of the python-musicbrainz2 package to lookup the ASIN based on the MusicBrainz albumid.  It requires the patch on bug #410681.

Another possibility is to get the ASIN when doing the original MusicBrainz lookup on the CD, but there is no simple GST_TAG_ location to store it.
Comment 2 Alex Lancaster 2007-03-04 14:50:50 UTC
Created attachment 83894 [details] [review]
Improve error checking
Comment 3 Jonathan Matthew 2007-08-25 10:48:26 UTC
Created attachment 94308 [details] [review]
updated, simplified a bit

I think a bit more work needs to go in to this.  It's synchronous (although it seems pretty quick), and it could probably interact with the existing amazon search in some fashion to avoid duplicating work, since they're kind of searching the same result space.
Comment 4 Jonathan Matthew 2008-02-13 14:02:47 UTC
This could probably be reworked to use a thread for the musicbrainz query fairly easily.  Not sure what to do about the interaction between this and the regular search; maybe the regular search should just do nothing if the entry it's searching for has a musicbrainz album ID?
Comment 5 Jonathan Matthew 2009-08-29 10:32:03 UTC
I rewrote this to use the rb Loader thing (so it's asynchronous) and parse the xml itself (no python-musicbrainz dependency) and committed it.